After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144170 - gail needs to emit window:moved events when toplevels move about.
gail needs to emit window:moved events when toplevels move about.
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
unspecified
Other All
: Normal normal
: ---
Assigned To: padraig.obriain
padraig.obriain
AP2
Depends on:
Blocks:
 
 
Reported: 2004-06-11 15:21 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (4.85 KB, patch)
2004-06-15 16:09 UTC, padraig.obriain
none Details | Review
New proposed patch (1.77 KB, patch)
2004-07-26 10:23 UTC, padraig.obriain
none Details | Review

Description bill.haneman 2004-06-11 15:21:46 UTC
see also related bug 144169.
Comment 1 padraig.obriain 2004-06-11 15:47:55 UTC
Currently a "window:resize" is emitted whe a toplevel moves about. Are you
saying that the name of the event should be changed or that an additional event
should be emitted?
Comment 2 bill.haneman 2004-06-11 16:24:01 UTC
"resize" ought to be emitted when a toplevel's size changes, and "move" ought to
be emitted when the toplevel is repositioned.  We could consider using a unified
"move-resize" event instead, of course.  But since we probably don't want to
remove the old event name altogether (for compatibility), perhaps add the new
one makes the most sense.  Is it difficult to distinguish between the two cases,
from an internal-implementation perspective?
Comment 3 padraig.obriain 2004-06-15 15:26:04 UTC
It is possible to distinguish between move and resize.

One concern I have is that on a window resize we may not be able to find out the
new size of the window if the GtkWindow does not change its allocation.
Comment 4 padraig.obriain 2004-06-15 16:09:29 UTC
Created attachment 28735 [details] [review]
Proposed patch
Comment 5 padraig.obriain 2004-06-16 10:00:03 UTC
Patch committed to CVS HEAD.
Comment 6 padraig.obriain 2004-07-22 09:29:21 UTC
I have found that this patch causes applets and menu not to be displayed on the
panel when GNOME is started with accessibility enabled. I have reverted the
patch.
Comment 7 bill.haneman 2004-07-23 12:15:28 UTC
IN order for magnifiers to track properly, we need a fix for this eventually.
Comment 8 korn 2004-07-23 14:42:26 UTC
I agree this should be fixed eventually.  However, is this really AP2 at this
point?  The two ways of moving/resizing a window at present are: (1) use the
mouse, or (2) use the keyboard [which moves the mouse].  Since magnification
tracking works when the mouse moves...
Comment 9 bill.haneman 2004-07-23 15:01:04 UTC
windows move and change size for reasons other than direct end-user action.

For instance, if panels/struts change, etc. or if users issue keyboard shortcuts
to the window manager, etc.

and of course, magnifier tracking isn't always using mouse-tracking mode.
Comment 10 bill.haneman 2004-07-23 15:01:56 UTC
I stand by AP2 since this means 'P3', i.e. not a stopper but still on the radar.
Comment 11 padraig.obriain 2004-07-26 10:23:14 UTC
Created attachment 29894 [details] [review]
New proposed patch

This patch causes resize or move signal to be emitted when top level window
moves and gnome-panel starts correctly when using this patch.
Comment 12 padraig.obriain 2004-07-26 10:38:40 UTC
New proposed patch committed to CVS HEAD.