GNOME Bugzilla – Bug 144016
applet loses Browse button and history button on a side panel
Last modified: 2004-12-22 21:47:04 UTC
1) Create a vertical panel (If it does not already exist) 2) Right Click on menu Add To Panel -> Utility -> Command Line Applet Actual Behavior: The browser and history buttons are not visible Expected Behavior: The browser and history buttons are visible.
The size requisition for the minicommander applet is completely broken, confirming.
Created attachment 28544 [details] [review] Proposed patch Solved the problem by changing layout of entry box and buttons depending on the orientation of the applet.
Heya, some comments: 1. Why are you including: +#include <stdlib.h> 2. The ChangeLog is missing. 3. - hbox = gtk_hbox_new (FALSE, 2); + if(mc->orient == PANEL_APPLET_ORIENT_UP || mc->orient == PANEL_APPLET_ORIENT_DOWN) + hbox = gtk_hbox_new (FALSE, 2); You change indenting here, you shouldn't do that. 4. I'm not sure but it might be an idea to look into using using size requisition. You can look at the gweather and wireless applet how this is done. It's a good start, keep up the good work!
Created attachment 28586 [details] [review] Proposed patch 1) I had included stdlib.h to get rid of a compiler warning due to exit() in function mini_commander_applet_fill (). But since this is not related to this bug, I have removed it. 2) Added ChangeLog 3) Made the indenting consistent. 4) size requisition will involve doing the whole thing again :( What is wrong with this solution? just wondering.
CVS HEAD actually included stdlib already your patch doesn't apply against CVS HEAD. Please update your CVS directory and update your patch against it. About requisition: Well the point is that applets should been seen as widgets nowadays, and widgets implement a size requisition. I know it's broken for most applets but we're slowly trying to fix it. Another reason is that the size that is returned by the panel is normalized and not exact. The reason why this is not fixed is because we should use requisition anyway. Also for future features, like applets in nautilus icons requisition is important. However, seen we need the widget replacement for this applet anyway i'll commit the patch when you've updated it to current CVS. I would be very happy if you could also have a look at size requisition but that is totally up to you.
Is this still being worked on ? Otherwise I'll try to come up with a patch.
Please go ahead
Created attachment 29325 [details] [review] patch This patch makes the mini-commander applet follow the panel size consistently. Based on the panel size and orientation, it tries to select a sensible layout for the applet entry and buttons.
Applied Vincents patch. Bug now fixed. Thanks guys!