After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143877 - Use Pango fonts when printing
Use Pango fonts when printing
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
gedit QA volunteers
: 143906 (view as bug list)
Depends on: 143874
Blocks:
 
 
Reported: 2004-06-07 15:32 UTC by Owen Taylor
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Pango font names (24.67 KB, patch)
2004-06-07 15:33 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2004-06-07 15:32:28 UTC
With the changes from bug 143874, GtkSourceView natively uses Pango
fonts for printing and GnomePrint font names are only supported
for backwards compatibility.

This patch switches gedit over to using GtkFontButton and using
Pango font names.

The main complexity in the patch is backwards compatibility with 
the GConf keys - a new set of GConf keys suffixed with _pango
keys are added, and when looking up a font preference, the
algorithm:

 - If the new key is set explicitely, use that
 - If the old key is set explicitely, use that and convert to a 
   Pango font name
 - Otherwise, use the default value for the new key

Setting the key sets the new key only. This system should allow
new and old versions of gedit to be used with the same GConf database.

The files dialogs/gnome-print-font-picker.c
gnome-print-font-dialog.[ch] should be removed when applying this patch.
Comment 1 Owen Taylor 2004-06-07 15:33:31 UTC
Created attachment 28433 [details] [review]
Use Pango font names
Comment 2 Paolo Maggi 2004-06-08 08:17:49 UTC
*** Bug 143906 has been marked as a duplicate of this bug. ***
Comment 3 Paolo Maggi 2004-11-09 17:30:11 UTC
Thanks for the patch.