After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143702 - Listener registered with SPI_KEYMASK_NUMLOCK gets events without NUMLOCK bit set
Listener registered with SPI_KEYMASK_NUMLOCK gets events without NUMLOCK bit set
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: registry
unspecified
Other Linux
: Normal minor
: ---
Assigned To: bill.haneman
bill.haneman
AP3
Depends on:
Blocks:
 
 
Reported: 2004-06-04 11:29 UTC by Dana Ormenisan
Modified: 2006-07-20 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a standalone tester (2.93 KB, text/plain)
2004-06-04 11:32 UTC, Dana Ormenisan 		  Details
patch to set NUMLOCK modifier if present, in key event listener notify (713 bytes, patch)
2006-07-19 20:34 UTC, bill.haneman 		committed Details | Review

Description Dana Ormenisan 2004-06-04 11:29:46 UTC 
If I register a listener with SPI_KEYMASK_NUMLOCK modifier, this listener will
be called with SPI_KEYMASK_MOD2.
Comment 1 Dana Ormenisan 2004-06-04 11:32:19 UTC 
Created attachment 28335 [details]
a standalone tester
Comment 2 Dana Ormenisan 2004-06-04 11:45:16 UTC 
Perhaps this issue is related with two older bugs: bug #128959 and bug #129103 ?
Comment 3 bill.haneman 2004-06-04 14:51:21 UTC 
This is not a bug; as I have reported elsewhere, KEYMASK_NUMLOCK is sometimes
mapped to MOD1 and sometimes MOD2 depending on the system/xserver in use.

However if SPI_KEYMASK_NUMLOCK is not also reported, that might be considered an
RFE for at-spi (to synthesize the NUMLOCK mask bit as appropriate to the
keyboard in use).
Comment 4 bill.haneman 2004-06-04 14:53:09 UTC 
changing summary to reflect fact that the NUMLOCK mask bit is missing (the MOD
bit is correct and appropriate).
Comment 5 bill.haneman 2004-06-04 14:53:51 UTC 
new summary reflects the part of the observed behavior that's actually a bug. 
The MOD bits are expected, but it would be useful if the NUMLOCK bit were set as
well.
Comment 6 Calum Benson 2004-10-21 16:52:40 UTC 
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 7 bill.haneman 2006-07-19 20:34:34 UTC 
Created attachment 69196 [details] [review]
patch to set NUMLOCK modifier if present, in key event listener notify
Comment 8 Frederic Peters 2006-07-20 21:00:28 UTC 
http://jhbuild.bxlug.be/builds/2006-07-20-0005/logs/at-spi/#build

  deviceeventcontroller.c: In function `spi_controller_notify_keylisteners':
  deviceeventcontroller.c:1445: error: assignment of read-only member `modifiers'

key_event is marked as *const* but the patch modifies its value.
Comment 9 bill.haneman 2006-07-20 22:00:52 UTC 
Oddly, this seems to build fine in my env.
Comment 10 bill.haneman 2006-07-20 22:05:59 UTC 
confirmed, it's a warning only in my env.  Fixing.