After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143251 - GtkFileChooserEntry pulldown icons
GtkFileChooserEntry pulldown icons
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
Other All
: Normal enhancement
: Medium feature
Assigned To: James Cape
James Cape
Depends on:
Reported: 2004-05-27 02:45 UTC by James Cape
Modified: 2014-12-23 11:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch to implement mimetype icons in the GtkFileChooserEntry completion (2.37 KB, patch)
2004-05-27 02:47 UTC, James Cape
needs-work Details | Review
Updated patch to use SMALL_TOOLBAR icon size and monitor size changes (6.25 KB, patch)
2004-05-31 22:53 UTC, James Cape
none Details | Review
Last patch minus the "invalid signal" emission. (6.19 KB, patch)
2004-06-01 01:25 UTC, James Cape
none Details | Review
Updated patch. (8.67 KB, patch)
2004-10-02 18:43 UTC, James Cape
rejected Details | Review

Description James Cape 2004-05-27 02:45:51 UTC
The GtkFileChooserEntry widget (used by the ctrl+l dialog) currently does not
show icons next to filenames, though the file chooser does display icons in the
list itself.
Comment 1 James Cape 2004-05-27 02:47:09 UTC
Created attachment 28062 [details] [review]
Patch to implement mimetype icons in the GtkFileChooserEntry completion
Comment 2 Federico Mena Quintero 2004-05-31 17:45:30 UTC
Thanks for the patch!  Instead of hard-coding 16 as an icon size, use
impl->icon_size, which gets computed from the theme.
Comment 3 James Cape 2004-05-31 22:53:32 UTC
Created attachment 28215 [details] [review]
Updated patch to use SMALL_TOOLBAR icon size and monitor size changes
Comment 4 James Cape 2004-06-01 01:25:04 UTC
Created attachment 28218 [details] [review]
Last patch minus the "invalid signal" emission.
Comment 5 Vincent Noel 2004-08-05 21:57:32 UTC
ping : can this patch be applied ?
Comment 6 James Cape 2004-08-07 19:06:17 UTC
This patch needs to also override the "screen-changed" signal with something
like this:

static void
gtk_file_chooser_entry_screen_changed (GtkWidget *widget,
                                       GdkScreen *previous_screen)
  GtkFileChooserEntry *entry;

  entry = GTK_FILE_CHOOSER_DEFAULT (widget);

  if (GTK_WIDGET_CLASS (parent_class)->screen_changed)
    GTK_WIDGET_CLASS (parent_class)->screen_changed (widget, previous_screen);

  if (entry->settings_notify_id)
      g_signal_handler_disconnect (gtk_settings_get_for_screen (previous_screen),
      entry->settings_notify_id = 0;
  check_icon_theme (entry);

Unfortunately, I'm unable to easily do this myself, as I've only got barebones
browser access to the Internet until the 17th.
Comment 7 Vincent Noel 2004-10-01 20:44:32 UTC
James : can you provide an updated version of the patch ? If you don't have time
maybe I'll give it a try...
Comment 8 James Cape 2004-10-02 18:43:43 UTC
Created attachment 32174 [details] [review]
Updated patch.

Here ya go :-)
Comment 9 James Cape 2004-10-02 18:51:51 UTC
I've updated the patch, it appears to work here (and does volume icons as well)
Comment 10 Matthias Clasen 2004-11-24 03:23:42 UTC
Comment on attachment 32174 [details] [review]
Updated patch.

I don't think we want to do anything which slows down the popup further,
although icons would be a nice touch. Can we come up with an approach which
loads the icons asynchronously ?
Comment 11 Christian Neumair 2005-01-31 18:22:38 UTC
James: Have you investigated the async proposal? Sounds quiet reasonable.
Comment 12 James Cape 2005-02-01 10:51:40 UTC
Not at all. I can try to take a look at it, but I honestly doubt I'll have the time.
Comment 13 Matthias Clasen 2014-12-23 11:53:51 UTC
never happened, sadly