After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143237 - gdk_device_get_state not implemented for extended input devices (tablets) on win32
gdk_device_get_state not implemented for extended input devices (tablets) on ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.4.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2004-05-26 20:13 UTC by Robert Ögren
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to implement gdk_device_get_state for extended input devices in the Win32 port of GTK+ (3.03 KB, patch)
2004-05-26 20:31 UTC, Robert Ögren 		none Details | Review

Description Robert Ögren 2004-05-26 20:13:15 UTC 
The function gdk_device_get_state in gdk/win32/gdkinput-win32.c is not
implemented for extended input devices (tablets) (gdk-2-4 branch from anoncvs
updated today). This causes problems, for example in The GIMP 2.0.1 when holding
down the Ctrl key to use the eyedropper, or when holding the Shift key to draw
straight lines (the line extends from the upper left corner of the window
instead of from the last clicked point).

A very simple way of implementing this function is to use the last known device
button and axes state in the GdkDevicePrivate structure. I have implemented this
and it seems to work well for me (because tablets send frequent updates as soon
as the stylus/puck is in proximity so the last known axes info is never old).
This has been tested using a Wacom Graphire 3 USB tablet on Windows XP.

A patch will be attached.

Note that even after this has been patched there is another problem with using
the shift key for the pen tool, but that is a separate bug which will be filed
later.
Comment 1 Robert Ögren 2004-05-26 20:31:42 UTC 
Created attachment 28045 [details] [review]
Patch to implement gdk_device_get_state for extended input devices in the Win32 port of GTK+

Suggested patch (against gtk-2-4 branch from anoncvs).
Comment 2 Tor Lillqvist 2004-05-27 02:16:08 UTC 
Thanks again. Patch applied to HEAD and gtk-2-4.