After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 143124 - Preferences dialog closing
Preferences dialog closing
Status: VERIFIED FIXED
Product: conglomerate
Classification: Other
Component: Code
CVS
Other Linux
: Normal normal
: ---
Assigned To: conglomerate list
conglomerate list
: 150150 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-05-25 12:33 UTC by Keith Sharp
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to update prefs dialog button and attach callback / signal handler for button (2.82 KB, patch)
2004-05-25 12:34 UTC, Keith Sharp 		none Details | Review
Paying attentions to Keith Sharps work (4.41 KB, patch)
2004-08-15 11:59 UTC, Geert Stappers 		committed Details | Review

Description Keith Sharp 2004-05-25 12:33:16 UTC 
The preferences dialog has an Ok button rather than a Close button, and the
button has no effect (is not linked to a signal handler / callback).

A patch is attached that changes the button to a stock close button, and adds a
callback to close the dialog when the button is clicked.
Comment 1 Keith Sharp 2004-05-25 12:34:22 UTC 
Created attachment 27995 [details] [review]
Patch to update prefs dialog button and attach callback / signal handler for button
Comment 2 Geert Stappers 2004-08-15 11:48:19 UTC 
AFAICT is the actual code request in bug 125455
Comment 3 Geert Stappers 2004-08-15 11:59:42 UTC 
Created attachment 30550 [details] [review]
Paying attentions to Keith Sharps work

The patch is Keiths patch plus ChangeLog plus a reference to bug 125455 that
will be visible for the user.
Comment 4 Geert Stappers 2004-08-15 12:15:03 UTC 
*** Bug 150150 has been marked as a duplicate of this bug. ***
Comment 5 David Malcolm 2004-08-17 19:42:39 UTC 
Looks good to commit
Comment 6 Geert Stappers 2004-08-19 09:14:55 UTC 
Comment on attachment 30550 [details] [review]
Paying attentions to Keith Sharps work

patch applied
Comment 7 Geert Stappers 2004-08-19 09:16:22 UTC 
Considered as FIXED.
a VERIFIED comment would be welcome.
Comment 8 Michèle Garoche 2004-08-21 06:59:42 UTC 
Verified. Works fine.
Comment 9 Geert Stappers 2004-08-21 10:25:04 UTC 
Okay, I'm closing it.