After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142823 - weather: Invalid
weather: Invalid
Status: RESOLVED DUPLICATE of bug 134452
Product: gnome-applets
Classification: Other
Component: gweather
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 142403 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-05-20 09:29 UTC by Colin Leroy
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6

Attachments
patch to weather.c (965 bytes, patch)
2004-05-20 09:30 UTC, Colin Leroy 		none Details | Review

Description Colin Leroy 2004-05-20 09:29:23 UTC 
There's a bit of parsing missing in gweather. I often got "Invalid" in Toulouse
(France). 
Gave a look to the source, an it appears that it is due to METAR reporting
"CAVOK" instead of "CLR..." "FEW..." etc. 

After looking a bit around, I saw that CAVOK is:
 CAVOK. This means ceiling and visibility OK and is used to replace weather and  
 clouds if visibility is 10 kilometers or more, there are no clouds below 1500 
 meters (5000 feet) or below the highest minimum air traffic control sector 
 altitude, whichever is greater. Also, there must be no other significant 
 weather.

So it's too sunny there, looks like ;-)

Attached is a patch that handles CAVOK as CLR.
Comment 1 Colin Leroy 2004-05-20 09:30:32 UTC 
Created attachment 27867 [details] [review]
patch to weather.c
Comment 2 Dennis Smit 2004-05-20 10:29:16 UTC 
Btw, kaushal, the PATCH keyword is no longer needed, you can filter
on attachment types using the query and that is what we use nowadays.
__


Thanks for the patch, we'll look into it!
Comment 3 Kevin Vandersloot 2004-05-20 13:27:05 UTC 
*** Bug 142403 has been marked as a duplicate of this bug. ***
Comment 4 Kaushal Kumar 2004-05-21 04:41:19 UTC 
Luis: FWIW, could we then have the 'PATCH' keyword removed from the list. I can
see people still add it after a patch.
Comment 5 Colin Leroy 2004-05-21 06:47:51 UTC 
Hi,

I missed, before filing, the bug #134452 which seems to be the same. It has a
patch also, seems to handle more cases. Maybe this bug's a dupe of bug #134452 ?
Comment 6 Kevin Vandersloot 2004-05-22 13:52:45 UTC 
Yah, sounds like it. Marking as duplicate but please reopen if not.

*** This bug has been marked as a duplicate of 134452 ***