After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142806 - Common version creation code with error check
Common version creation code with error check
Status: RESOLVED OBSOLETE
Product: f-spot
Classification: Other
Component: Editing
CVS
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
: 343575 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-05-19 23:04 UTC by Larry Ewing
Modified: 2010-06-25 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Presents a dialog, as well as updates menu's (3.45 KB, patch)
2005-08-18 15:51 UTC, Bengt Thuree
none Details | Review
Updated patch (2.52 KB, patch)
2005-08-19 13:57 UTC, Bengt Thuree
committed Details | Review

Description Larry Ewing 2004-05-19 23:04:54 UTC
We need to handle the case where you are creating a modified version and the
filename already exsists.
Comment 1 Bengt Thuree 2005-08-18 15:51:34 UTC
Created attachment 50922 [details] [review]
Presents a dialog, as well as updates menu's

Presents a dialog window when an error occurs during rename, create or delete.
In addition it also fixes a fault with Version names not beein updated in the
menu system when versions are beeing added, renamed or deleted.
Comment 2 Bengt Thuree 2005-08-19 13:57:23 UTC
Created attachment 50983 [details] [review]
Updated patch

This patch only presents a dialog if something goes wrong.
For the problem with updating the menu's, please check bug
http://bugzilla.gnome.org/attachment.cgi?bugid=313850
Comment 3 Larry Ewing 2005-09-27 07:00:16 UTC
The solution to this needs to be more general we create versions on every edit
of the original file as well, so they need to be protected.  So to really fix
this the version creation code for the edits also needs to be centralized then
we need to handle the exception.
Comment 4 Alexander “weej” Jones 2005-12-12 18:53:42 UTC
Also on a file system with versioning support, integrate nicely into that.

For non-versioning file systems, maybe tar up the old versions or throw them in
an "Old Versions" folder? 2 nasty ideas, but how do you deal with it? Tagging a
number on the end of the filename is just shit because they show up in Nautilus
etc. all over.
Comment 5 Larry Ewing 2006-02-12 07:50:13 UTC
Committed this patch, I'm leaving the bug open for not based on my previous comments.
Comment 6 Bengt Thuree 2006-02-12 11:43:38 UTC
To my embarrasment, there seems to be some missing quotation marks (") in this patch :(

Observe the last "

The exception string should look like this
("Received exception \"{0}\". Unable to create version to \"{1}\"")
("Received exception \"{0}\". Unable to delete version to \"{1}\"")
("Received exception \"{0}\". Unable to rename version to \"{1}\"")
Comment 7 Larry Ewing 2006-02-12 17:40:28 UTC
yeah I saw your mail after I'd already fixed this :)
Comment 8 Bengt Thuree 2006-05-18 03:53:28 UTC
Changed title to reflect new situation.
Comment 9 Stephane Delcroix 2006-06-01 10:00:52 UTC
another problem related to this: # 343575
Comment 10 Larry Ewing 2006-10-05 03:41:48 UTC
*** Bug 343575 has been marked as a duplicate of this bug. ***