After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142540 - build breaks due to duplicate gtkcellrendererprogress.h
build breaks due to duplicate gtkcellrendererprogress.h
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other Linux
: Normal blocker
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2004-05-14 13:21 UTC by david.hawthorne
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to build with updated gtk+ (1.13 KB, patch)
2004-05-14 13:23 UTC, david.hawthorne 		none Details | Review
revised patch to check for updated gtk+ (1.81 KB, patch)
2004-05-19 14:44 UTC, david.hawthorne 		none Details | Review
said sed patch, requiring no new gtk+ dependency (6.21 KB, patch)
2004-05-19 16:00 UTC, david.hawthorne 		none Details | Review

Description david.hawthorne 2004-05-14 13:21:41 UTC 
compiling procman from CVS HEAD 14/05/04

- gtk+ introduced gtkcellrendererprogress.h on 12/05/04, and so there is a clash
between this and procman's own gtkcellrendererprogress.h

the following make error:

In file included from interface.c:38:
cellrenderer.h:29:1: warning: "GTK_TYPE_CELL_RENDERER_PROGRESS" redefined
In file included from /opt/gnome-2.7/include/gtk-2.0/gtk/gtk.h:51,
                 from /opt/gnome-2.7/include/libgnomeui-2.0/gnome.h:4,
                 from procman.h:23,
                 from interface.c:31:
/opt/gnome-2.7/include/gtk-2.0/gtk/gtkcellrendererprogress.h:34:1: warning: this
is the location of the previous definition
In file included from interface.c:38:
cellrenderer.h:32: redefinition of `GtkCellRendererProgress'
`GtkCellRendererProgress' previously declared here
cellrenderer.h:33: redefinition of `GtkCellRendererProgressClass'
/opt/gnome-2.7/include/gtk-2.0/gtk/gtkcellrendererprogress.h:42:
`GtkCellRendererProgressClass' previously declared here
cellrenderer.h:36: redefinition of `struct _GtkCellRendererProgress'
cellrenderer.h:41: redefinition of `struct _GtkCellRendererProgressClass'
make[2]: *** [interface.o] Error 1
make[2]: Leaving directory `/gnome/2.4/nightly/src-2.7-20040514/procman/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/gnome/2.4/nightly/src-2.7-20040514/procman'
make: *** [all-recursive-am] Error 2

attaching patch to remove gtkcellrendererprogress.h from callbacks.c and
interface.c and use the gtk+ header instead.
Comment 1 david.hawthorne 2004-05-14 13:23:41 UTC 
Created attachment 27695 [details] [review]
patch to build with updated gtk+
Comment 2 Kevin Vandersloot 2004-05-19 14:27:04 UTC 
Patch looks good, though we should also put a configure.in check to get the
newer version of gtk+
Comment 3 david.hawthorne 2004-05-19 14:44:35 UTC 
Created attachment 27845 [details] [review]
revised patch to check for updated gtk+
Comment 4 Kevin Vandersloot 2004-05-19 15:08:40 UTC 
Actually come to think of it, I don't know if we can depend on gtk 2.6 for the
next GNOME release. I think for now we should probably do a sed job on procman's
local version of gtkcellrenderprogress to change to name to
procmancellrendererprogress or something like that.
Comment 5 david.hawthorne 2004-05-19 16:00:13 UTC 
Created attachment 27846 [details] [review]
said sed patch, requiring no new gtk+ dependency
Comment 6 Paolo Borelli 2004-10-29 08:32:12 UTC 
gnome 2.10 will depend on gtk 2.6.
Comment 7 Benoît Dejean 2005-03-10 09:23:04 UTC 
Fixed in HEAD.