GNOME Bugzilla – Bug 141624
Use a generic password dialog API
Last modified: 2007-12-28 21:16:31 UTC
Currently, the passwd dialog for the unlock keyring action is beign recycled, but that does not work because the action can be called for different keyrings, and that causes problems, clearly. Think a bit about this before coding, so that it does not get too complicated, while retaining the ability to recycle passwd dialogs when the user tries to unlock _the_ _same_ keyring twice.
I've commited the following patch which sets things up so that at most one passwd dialog is shown at a time. It thus closes any existing passwd dialog before presenting a new one. The alternative is more complicated to code, and would end up be confusing.
Created attachment 27375 [details] [review] Allow at most 1 passwd dialog at a time.
Created attachment 27395 [details] [review] Patch makes the password dialog generic Patch makes it possible to use a password dialog API for various purposes in gnome-keyring-manager, e.g. Unlock keyring, Open Keyring, Create new keyring, etc. The dialogs shown by gnome-keyring-daemon are not consistent with gnome-keyring-manager and hence custom password dialogs are required.
Created attachment 27399 [details] [review] updated patch for "patch makes the password dialog generic" Patch corrects API documentation bug in earlier patch.
Hmm, we now have a whole gnome-keyring-manager-password-dialog.c... Does this patch still make sense, Patanjali?
gnome-keyring-manager-password-dialog.c was removed after a cleanup and change in UI. It this patch still valid?
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for. Thanks!