After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 141072 - tests/testgtk.c: many warnings fixed
tests/testgtk.c: many warnings fixed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.4.x
Other Linux
: Normal normal
: Small fix
Assigned To: gtk-bugs
gtk-bugs
: 141071 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-04-25 14:02 UTC by Chris Sherlock
Modified: 2006-09-11 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (943 bytes, patch)
2004-04-25 14:03 UTC, Chris Sherlock
none Details | Review
Proposed patch (2.35 KB, patch)
2004-04-25 14:43 UTC, Chris Sherlock
none Details | Review
Removes unused functions opacity_toggled_cb and palette_toggled_cb (828 bytes, patch)
2004-04-25 14:49 UTC, Chris Sherlock
none Details | Review

Description Chris Sherlock 2004-04-25 14:02:21 UTC
All fixed:

testgtk.c: In function `create_gridded_geometry':
testgtk.c:1983: warning: dereferencing type-punned pointer will break
strict-aliasing rules
testgtk.c: In function `create_key_lookup':
testgtk.c:4159: warning: dereferencing type-punned pointer will break
strict-aliasing rules
testgtk.c: In function `find_widget_at_pointer':
testgtk.c:11253: warning: dereferencing type-punned pointer will break
strict-aliasing rules

Not fixed (not sure whether to remove these functions or not...):

testgtk.c: At top level:
testgtk.c:7304: warning: `opacity_toggled_cb' defined but not used
testgtk.c:7315: warning: `palette_toggled_cb' defined but not used
Comment 1 Chris Sherlock 2004-04-25 14:03:43 UTC
Created attachment 27073 [details] [review]
Proposed patch
Comment 2 Chris Sherlock 2004-04-25 14:18:04 UTC
*** Bug 141071 has been marked as a duplicate of this bug. ***
Comment 3 Chris Sherlock 2004-04-25 14:43:58 UTC
Created attachment 27074 [details] [review]
Proposed patch

I think I've got an invalid patch here... try this new one instead.
Comment 4 Chris Sherlock 2004-04-25 14:49:00 UTC
Created attachment 27075 [details] [review]
Removes unused functions opacity_toggled_cb and palette_toggled_cb

Use this patch after you've used patch 27074, and only if we really want to get
rid of these functions.
Comment 5 Tim Janik 2006-09-11 12:25:11 UTC
thanks, fixed in CVS.

Mon Sep 11 14:22:39 2006  Tim Janik  <timj@imendio.com>
        * tests/testgtk.c: fixed compiler warnings.