After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140604 - gail code fixes (strict aliasing, unused code etc.)
gail code fixes (strict aliasing, unused code etc.)
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
1.6.2
Other Linux
: Normal normal
: ---
Assigned To: padraig.obriain
padraig.obriain
Depends on:
Blocks:
 
 
Reported: 2004-04-20 14:36 UTC by Stanislav Brabec
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gail-strict-aliasing.patch (5.89 KB, patch)
2004-04-20 14:37 UTC, Stanislav Brabec
none Details | Review
gail-void.patch (3.55 KB, patch)
2004-04-20 14:37 UTC, Stanislav Brabec
none Details | Review
gail-errors.patch (324 bytes, patch)
2004-04-20 14:38 UTC, Stanislav Brabec
none Details | Review
gail-uninitialized.patch (1.41 KB, patch)
2004-04-20 14:39 UTC, Stanislav Brabec
none Details | Review
gail-unused-vars.patch (1.99 KB, patch)
2004-04-20 14:39 UTC, Stanislav Brabec
none Details | Review
gail-unused-func.patch (4.29 KB, patch)
2004-04-20 14:40 UTC, Stanislav Brabec
none Details | Review
gail-warn.patch (715 bytes, patch)
2004-04-20 14:40 UTC, Stanislav Brabec
none Details | Review

Description Stanislav Brabec 2004-04-20 14:36:43 UTC
Attached patches fixes most gcc warnings in code (apply in this order):
gail-strict-aliasing.patch: Fixes code for latest gcc aliasing analysis.
gail-void.patch: Fixed void functions declarations.
gail-errors.patch: Fixes code error (gcc warning).
gail-uninitialized.patch: Fixes potentially uninitialized variables.
gail-unused-vars.patch: Removes uninitialized variables.
gail-unused-func.patch: Removes uninitialized functions.
gail-warn.patch: Fixes minor warnings.

Not yet fixed warnings:
gaillabel.c: In function `gail_label_ref_relation_set':
gaillabel.c:500: warning: assignment from incompatible pointer type
gaillabel.c: In function `gail_label_real_notify_gtk':
gaillabel.c:315: warning: `top_level' might be used uninitialized in this function
testlib.c: In function `get_arg_of_func':
testlib.c:836: warning: `retString' might be used uninitialized in this function
Comment 1 Stanislav Brabec 2004-04-20 14:37:16 UTC
Created attachment 26866 [details] [review]
gail-strict-aliasing.patch
Comment 2 Stanislav Brabec 2004-04-20 14:37:59 UTC
Created attachment 26867 [details] [review]
gail-void.patch
Comment 3 Stanislav Brabec 2004-04-20 14:38:38 UTC
Created attachment 26868 [details] [review]
gail-errors.patch
Comment 4 Stanislav Brabec 2004-04-20 14:39:26 UTC
Created attachment 26869 [details] [review]
gail-uninitialized.patch
Comment 5 Stanislav Brabec 2004-04-20 14:39:52 UTC
Created attachment 26870 [details] [review]
gail-unused-vars.patch
Comment 6 Stanislav Brabec 2004-04-20 14:40:22 UTC
Created attachment 26871 [details] [review]
gail-unused-func.patch
Comment 7 Stanislav Brabec 2004-04-20 14:40:45 UTC
Created attachment 26872 [details] [review]
gail-warn.patch
Comment 8 padraig.obriain 2004-04-21 09:08:21 UTC
Patches applied, with some minor changes.

Other warnings also adderssed.