After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140429 - Open dialog doesn't have filters
Open dialog doesn't have filters
Status: RESOLVED DUPLICATE of bug 137952
Product: gpdf
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Martin Kretzschmar
Martin Kretzschmar
Depends on:
Blocks:
 
 
Reported: 2004-04-18 18:39 UTC by Sathwik Ramaswamy
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch adds filters to the open dialog.... (1.22 KB, patch)
2004-04-18 18:44 UTC, Sathwik Ramaswamy 		none Details | Review

Description Sathwik Ramaswamy 2004-04-18 18:39:16 UTC 
Module: GPDF (GNOME PDF Viewer)
Version: 0.130

Description:

Start gpdf. Click Open... The file chooser lists all the files present in a 
given directory. 

Instead, it would be better to give an option(in the form of a combo box) to 
either select the pdf files or All files ... similar to other modules, thus 
eliminating the need to search for the required files in the list.
 
Regards
Sathwik.R
Comment 1 Sathwik Ramaswamy 2004-04-18 18:44:00 UTC 
Created attachment 26786 [details] [review]
The patch adds filters to the open dialog.... 

Hope the programming style is in accordance with the standard one ...

Also..the unified diff is submitted..
Comment 2 Martin Kretzschmar 2004-04-18 19:23:03 UTC 
Sorry, you're not the first to submit a patch for that bug, there's already one
in bug 137952. Better search for existing bugs before writing the patch to avoid
duplicate work.

If I had to review the patch, I'd say:

 * gpdf can't open PostScript files
 * gtk_file_filter_add_mime_type (pdf_filter, "application/pdf") is better than
gtk_file_filter_add_pattern(filter, "*.pdf")
 * gtk_file_chooser_set_local_only(GTK_FILE_CHOOSER(chooser), TRUE); doesn't
seem to be related to the missing filters.

*** This bug has been marked as a duplicate of 137952 ***