What presentation mode are you using ? Are you using default or verbose? (see
gnopernicus->2 Preferences...->7 Presentation).

Ah. I'm using verbose and it does not happen when using default. Should this
happen however even with verbose?

Using default presentation mode, gnopernicus outputs the name for a push button.

Using verbose, gnopernicus outputs both name and description for a push button.
In this case, the two information are identical (terminal...). Beacause of that,
this 'double output' occurs.

Is the bug in libwnck in that the buttons should not have name and description
the same?

I don't know, but I think name and description should be different. Why shold we
describe an object using its name ?

I believe the only solution (in gnopernicus) for this problem is to check if
name and description are the same and, in this particular situation, to output
only the name (in verbose presentation mode).

Created attachment 26255 [details] [review]
proposed patch to avoid this 'double output'

I was hoping that Bill or Peter would comment on whether it is a bug for an
object to report its name and description as the same.

The problem here is that the accessible description is the tooltip and the
tooltip for the tasklist button is the same as the text on the button.

Avoiding the double output in gnopernicus looks like the best approach.

The previous patch avoid the double output if the button has an accessible name
and a description and both are the same.  
But if the button doesn't have an accessible name the double output is still
present: in this situation (if no name) the description is presented as a name
for this object.

What decision should we take here: avoid the double output in gnopernicus (by
applying this patch) and file bugs against <no name> objects? Or require a
different name an description for an object?

Please comment !

I would do something a bit different: I would avoid the double output by:

* not substituting "description" to obtain "accessible-name"
* speaking the "description" instead of "name" in cases where no name is present,
  _but_ only apply this login in the presentation layer, i.e. if we're not
  speaking the description already.

i.e.
if (say_description)
       present_to_user (name, description, etc.)
else if (name)
       present_to_user (name, etc.)
else
       present_to_user (description, etc.)

Created attachment 28691 [details] [review]
new proposed patch - this patch avoid the double output described in comment #10

In default presentation mode gnopernicus doesn't output the description, only
the name. In this case, if the button doesn't have an accessible name, the
output will be only 'push button'. This is the reason why the description is
presented as a name in this situation.

The solution to avoid the double output without any major changes is:
   if (no name)
	  the description will be presented as a name	 
	  present_to_user (name, etc.)
   else if (name == description)
	  present_to_user (name, etc.)
   else
	  present_to_user (name, description, etc.)

 Are you agree with this changes ?

I agree with your logic Dana, though I would use "description voice" if there is
one rather than "name voice" (e.g. don't present the description *as* the name;
don't hide from the user the info that this is the descriptoin).  I haven't
checked your code...

There are two different functions: one which returns the name and another one
for the description. If <no name>, the description is returned by the function
which should return the name. This is because in default presentation file we
have only one entry : 'present <name> using 'name' voice'. This is the reason
why, in this case, the description is presented with 'name' voice. 

Fixies in CVS