After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 138404 - [cygwin patch] Cygwin libcharset fix.
[cygwin patch] Cygwin libcharset fix.
Status: VERIFIED INCOMPLETE
Product: glib
Classification: Platform
Component: win32
2.4.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks: 137591
 
 
Reported: 2004-03-29 13:25 UTC by Roger Leigh
Modified: 2011-02-18 16:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rl-glib-CVSHEAD-cygwin-libcharset.patch (541 bytes, patch)
2004-03-29 13:26 UTC, Roger Leigh 		none Details | Review

Description Roger Leigh 2004-03-29 13:25:36 UTC 
Cygwin doesn't have an entry in config.charset.  This patch adds it.
Comment 1 Roger Leigh 2004-03-29 13:26:10 UTC 
Created attachment 26060 [details] [review]
rl-glib-CVSHEAD-cygwin-libcharset.patch

Against CVS HEAD.
Comment 2 Tor Lillqvist 2004-03-30 01:34:16 UTC 
Looks OK to commit.
Comment 3 Tor Lillqvist 2004-03-31 02:09:28 UTC 
Actually, wouldn't it be simpler to define WIN32 in localcharset.c also for 
Cygwin, and then not use the charset.alias file at all (even if it does get 
installed by the Makefile.am)? Doesn't Cygwin use the same code pages as native 
Win32 programs?
Comment 4 Roger Leigh 2004-04-29 23:17:04 UTC 
The entry in config.charset is not required.  The patch already applied to
localcharset.c fixes this.

I'm closing this bug.

Regards,
Roger