After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 138212 - IFS Compose Delete button sensitivity not updated
IFS Compose Delete button sensitivity not updated
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.0.x
Other Linux
: Normal normal
: 2.0
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2004-03-26 14:02 UTC by Yeti
Modified: 2004-03-28 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (2.31 KB, patch)
2004-03-26 14:02 UTC, Yeti
none Details | Review

Description Yeti 2004-03-26 14:02:13 UTC
The Delete button sensitivity is not properly updated on Reset, Load, Undo/Redo,
and parameter restore from parasite. This among other things allows deletion of
all transformations with consequent crash (of the plug-in).

A patch is attached.

Reproduction:
1. Run IFS Compose
2. Delete a transformation
3. Click on Reset -- now you can't delete a transformation even if there are 3
of them

1. Run IFS Compose
2. Delete a transformation
3. Click on OK
4. Re-run IFS Compose (now it displays only two transformations)
5. Click twice on Delete -- IFS Compose crashes

Etc.
Comment 1 Yeti 2004-03-26 14:02:47 UTC
Created attachment 25978 [details] [review]
Proposed patch
Comment 2 Sven Neumann 2004-03-26 14:22:58 UTC
This should at a later point be redone using GtkAction, but for now the patch
looks good.
Comment 3 Sven Neumann 2004-03-28 16:11:01 UTC
2004-03-28  Sven Neumann  <sven@gimp.org>

	* plug-ins/ifscompose/ifscompose.c: applied patch from David Necas
	that updates the sensitivity of the Delete button and menu entry.
	Fixes bug 138212#.

David, you don't mind seeing your name in the ChangeLog, do you? Oh, and could
you add -p to the diff options in your .cvsrc? That would make it easier for us
to review your patches.