After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 136457 - Applet icon not aligned vertically
Applet icon not aligned vertically
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: battery
2.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: 144413
 
 
Reported: 2004-03-07 15:22 UTC by Santiago Erquicia
Modified: 2010-01-24 01:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4

Attachments
Screeshot of the panel icon (11.35 KB, image/png)
2004-03-07 15:24 UTC, Santiago Erquicia 		  Details
patch for battstat applet (7.45 KB, patch)
2004-07-19 19:42 UTC, Vincent Noel 		none Details | Review

Description Santiago Erquicia 2004-03-07 15:22:17 UTC 
If the panel size is big enough, the battery applet is top aligned instead
of center aligned as the other icons.

I'm going to attach a screenshot showing this with a panel size exagerately
big.
Comment 1 Santiago Erquicia 2004-03-07 15:24:44 UTC 
Created attachment 25291 [details]
Screeshot of the panel icon
Comment 2 Danielle Madeley 2004-05-23 17:17:15 UTC 
That's rather amusing. Does it still exist in GNOME 2.6?
Comment 3 Dennis Smit 2004-05-23 18:17:09 UTC 
I think i've fixed this for 2.6 somewhere in the 2.5.x serie, not sure tho.
Comment 4 Danielle Madeley 2004-05-24 10:40:18 UTC 
Hmm, it's not actually that hard to check is it? It wouldn't appear to be
properly fixed.
Comment 5 Dennis Smit 2004-05-24 12:04:18 UTC 
Sorry i was in a hurry, but it's true i did screw up, it's still borked.
Comment 6 Vincent Noel 2004-07-19 19:42:48 UTC 
Created attachment 29667 [details] [review]
patch for battstat applet

This patch makes the applet centered on vertical and horizontal panels. 
I made the applet follow the panel size using size_allocate, so this has the
nice side effect of fixing bug #144413 as well.
Comment 7 Danielle Madeley 2004-07-20 14:46:51 UTC 
I've been meaning to check this out. It looked basically sane at a first glance.
Comment 8 Vincent Noel 2004-07-22 13:41:55 UTC 
What do you mean ? Do you have other plans for the battery applet ? Or a
complete rewrite ?
Comment 9 Danielle Madeley 2004-07-22 14:37:03 UTC 
I meant that I hadn't actually tested this patch for myself yet.
Comment 10 Vincent Noel 2004-08-02 15:48:37 UTC 
Has this patch been applied to HEAD ? Otherwise this bug is still present in
gnome-applets and the battery applet positioning is still wrong.
Comment 11 Danielle Madeley 2004-08-03 09:11:06 UTC 
Assuming it's not this one:

2004-07-09  Vincent Noel  <vnoel@cox.net>

        * battstat_applet.c (change_orient): Make the applet horizontal
        on wide vertical panels.

Then you should commit it so we can close this bug.
Comment 12 Vincent Noel 2004-08-03 13:59:27 UTC 
Unfortunately I don't have cvs access, otherwise I would have done it a while ago.
Comment 13 Kevin Vandersloot 2004-08-03 14:10:48 UTC 
Go ahead and commit it Davyd.
Comment 14 Danielle Madeley 2004-08-03 14:23:16 UTC 
Committed. Thanks Vincent.