GNOME Bugzilla – Bug 135985
should warn about available size
Last modified: 2005-01-07 21:39:31 UTC
The cd burner windows should somehow not allow the user to try to burn 2Giga onto one cd. Dunno if the best way is a warning saying that the amount of data exceeds the media capacity or what. This is especially true in the new spatial windows since IIRC there is no clue of how much data you currently have.
We can already detect the capacity of any CD/DVD media. We just need to hook all of this up.
*** Bug 148811 has been marked as a duplicate of this bug. ***
*** Bug 149500 has been marked as a duplicate of this bug. ***
perhaps it would be nice to have the current size displayed in real time (the size of the data to be burnt) in the status bar. For now I have to select all and choose "Properties". Or I miss something.
Created attachment 33484 [details] [review] Patch cheking for size, asking to replace (or overburn if diff is only 5MiBs) and replacing ncb_hig_dialog for the new gtk
Comments on the patch. I think it is better to fix the ncb_hig_dialog to use the new gtk_message_dialog_format_secondary_text() API rather than remove the function altogether. I think it is also necessary to sanity check the size before writing the ISO image (in addition to after). There is no point making the user wait while creating a 10GiB ISO that can't be written anywhere. I'll try to update this.
Created attachment 35514 [details] [review] updated patch Prompts for media insertion before creating ISO image.
Comment on attachment 35514 [details] [review] updated patch If you tested it, feel free to commit.
2005-01-07 William Jon McCann <mccann@jhu.edu> * make-iso.c (ask_disable_joliet, nautilus_burn_make_iso): Use gtk_message_dialog_format_secondary_text API. * nautilus-cd-burner.c (ncb_hig_dialog): Use gtk_message_dialog_format_secondary_text API. (ask_for_media, insert_media_request_cb, burn_cd, main): Ask the user to replace the in-drive media if data size is bigger than media size (and he hasn't the gconf overburn set). If difference is only 5 MiBs show a button to overburn it. Also show the required size in the insert disc dialog. Based on patch from Fernando Herrera <fherrera@onirica.com> (Closes: #135985)