GNOME Bugzilla – Bug 134995
percent complete should allow input with % sign
Last modified: 2004-12-22 21:47:04 UTC
The tasks percent complete should allow input with a % sign.
I think it is reasonable to support user input of both (in regex):
Currently, only numeric input is accepted. It seems this is because a
g_strtod() is used.
I'm feeing sort of dumb- where in the clock applet does it accept
percentages complete of anything?
If the applet is compiled with libecal (evolution-data-server) support
and you have tasks defined for the given day in e-d-s they will be
diplayed. The percentage complete of each task is displayed and is
editable by clicking directly on the text.
Actually any character other than a number will not be accepted.
For example if you input "25 " (with a whitespace) it will be discarded.
Created attachment 32575 [details] [review]
patch for applets/clock/clock.c
This patch filters percent and whitespace characters before evaluating the
This looks strange:
+ text_copy = g_strdelimit (text_copy, "% ", ' ');
i.e. why replace ' ' with ' ' ?
But apart from that it looks fine to commit
Good point. I have removed the space in the first argument, and changed the
following g_strchomp to a g_strstrip to get rid of all spaces. I've committed,
closing the bug.
*** Bug 160585 has been marked as a duplicate of this bug. ***