After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134754 - Configure's --with-html-dir option does not work (plus improvements)
Configure's --with-html-dir option does not work (plus improvements)
Status: RESOLVED FIXED
Product: libxslt
Classification: Platform
Component: general
git master
Other other
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-18 15:47 UTC by Julio Merino
Modified: 2009-08-21 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The proposed patch (3.41 KB, patch)
2004-02-18 15:47 UTC, Julio Merino
none Details | Review

Description Julio Merino 2004-02-18 15:47:19 UTC
The actual configure script in libxslt recognizes the --with-html-dir  
argument which is used to define the value of HTML_DIR.  Even though,  
this variable is later overriden by hardcoded values in all Makefile.am  
files using it, making the option useless.  
  
While fixing this, I've also done some improvements that will make  
packaging easier in pkgsrc, for example. Many other gnome packages  
(specially those using gtk-doc) install documentation under  
${HTML_DIR}/${PACKAGE}, beeing the first variable defined by the  
configure argument.  Even though, libxslt behaves differently, because it  
adds a trailing 'html/' to this path, resulting in undesired locations in  
our filesystem hierarchy (and probably in others).  
  
To allow all installation flavours, I've simply added another option,  
named --with-html-subdir, whose value is $(PACKAGE)-$(VERSION)/html by  
default.  
  
Note that this makes the package more consistent itself, because the html  
installation directory is defined in just one place, the configure  
script.  
  
The point is to not break the actual default behavior; that is, after  
applying the patch, libxslt will behave the same as before if no options  
are given.  But it will allow an easy customization of paths.  
  
The attached patch does this.  Note that the big chunks in the .am files  
are due to TARGET_DIR -> HTML_DIR renames, since the former becomes  
useless.
Comment 1 Julio Merino 2004-02-18 15:47:54 UTC
Created attachment 24518 [details] [review]
The proposed patch
Comment 2 Daniel Veillard 2009-08-21 14:13:50 UTC
Incredible, I only now discovered this patch, and it mostly applies
fine, so I'm commiting this. Not sure if this still helps ... but
that looks like improvements so :-)

  thanks and sorry for the slight delay !

Daniel