After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134685 - NautilusIconContainer widget uses "light background" text colours instead of dark with some GTK themes
NautilusIconContainer widget uses "light background" text colours instead of ...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
2.6.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-17 23:58 UTC by Chris Macksey
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
Screen Shot (218.23 KB, image/png)
2004-02-17 23:59 UTC, Chris Macksey
  Details
Patch (591 bytes, patch)
2004-02-17 23:59 UTC, Chris Macksey
none Details | Review

Description Chris Macksey 2004-02-17 23:58:29 UTC
The Nautilus "View as Icons" view uses the incorrect text color (light
background) instead of the correct (dark background) text color with some
GTK themes - namely (but possibly not exclusively), themes with a dark
bg[NORMAL] colour that use Ximian's Industrial engine.

Problem occurs because the widget "background" is not set, yet the widget
calls eel_background_is_dark() on it.   The default behaviour of
eel_background_is_dark() is to treat the background as white, if unknown. 
This is incorrect in this circumstance.

I will attach a screenshot (to prove I'm not crazy, or at least, not crazy
about this particular thing), and a patch which fixes the problem.
Comment 1 Chris Macksey 2004-02-17 23:59:13 UTC
Created attachment 24501 [details]
Screen Shot
Comment 2 Chris Macksey 2004-02-17 23:59:44 UTC
Created attachment 24502 [details] [review]
Patch
Comment 3 Chris Macksey 2004-04-15 14:54:07 UTC
Updating this to reflect that this bug is still in Nautilus 2.6.0 (I just
upgraded).  The same code fix applies, although the screenie would be different ;)
Comment 4 Dave Camp 2004-04-30 18:03:42 UTC
I just committed this to cvs, thanks!