After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134331 - [UI-REVIEW] Extra frame around controls causes unneeded noise
[UI-REVIEW] Extra frame around controls causes unneeded noise
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ronald Bultje
gnome media maintainers
Depends on:
Blocks: 134328
 
 
Reported: 2004-02-13 17:01 UTC by Seth Nickell
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix extra border problem (1.88 KB, patch)
2004-02-29 23:45 UTC, Seth Nickell
none Details | Review

Description Seth Nickell 2004-02-13 17:01:37 UTC
There's currently a border (frame probably) encompassing the mixer widgets.
It doesn't contribute useful grouping information (since it basically
covers the whole window), and adds extra visual noise. The border around
the mixer widgets should be removed.
Comment 1 Ronald Bultje 2004-02-29 22:18:32 UTC
Hi Seth, I'll handle this. Can you explain which of the borders you
mean (which line of code)? I'm not aware of any "unneeded" border.
Comment 2 Seth Nickell 2004-02-29 23:45:47 UTC
Created attachment 24954 [details] [review]
Patch to fix extra border problem
Comment 3 Seth Nickell 2004-02-29 23:47:14 UTC
The problem was that GtkScrolledWindow was created with an automatic
GtkViewport, an GtkViewport defaults to having GTK_SHADOW_TYPE_IN
rather than NONE. Attached patch fixes.
Comment 4 Ronald Bultje 2004-03-01 04:10:33 UTC
Applied to CVS, thanks!