After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134036 - GOK-0.9.6 compile errors
GOK-0.9.6 compile errors
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: build
unspecified
Other FreeBSD
: Normal major
: ---
Assigned To: David Bolter
David Bolter
: 134067 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-02-10 18:55 UTC by Joe Marcus Clarke
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (2.97 KB, patch)
2004-02-11 09:49 UTC, padraig.obriain
none Details | Review

Description Joe Marcus Clarke 2004-02-10 18:55:29 UTC
GOK 0.9.6 has a few compilations issues with GCC 2.95 as well as with the
distfile in general.  First, there are some C99-isms in gok/gok-key.c,
gok/gok-keyboard.c, and gok/gok-spy.c  The gok-key.c problems are around
line 372 with the gchar cbuf.  The gok-keyboard.c problems are at line 185
with the compose_kbd, prev, and next declarations.  The gok-spy.c problem
is around line 1393 with the head declaration.

The distfile complaint is with the missing GNOME_Gok.server.in.in file:

*** No rule to make target 'GNOME_Gok.server.in.in', needed by
'GNOME_Gok.server.in'

This is the gok subdirectory.
Comment 1 padraig.obriain 2004-02-11 08:46:53 UTC
*** Bug 134067 has been marked as a duplicate of this bug. ***
Comment 2 padraig.obriain 2004-02-11 09:49:35 UTC
Created attachment 24296 [details] [review]
Proposed patch
Comment 3 bill.haneman 2004-02-11 11:39:20 UTC
Thanks Padraig, please apply.  I'll redist.
Comment 4 padraig.obriain 2004-02-11 13:12:33 UTC
Patch committed to CVS HEAD.
Comment 5 bill.haneman 2004-02-11 14:27:11 UTC
oddly, building gok with -Werror and -ansi did not catch these.