After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 133692 - shell/gpdf.c uses GTK 2.3 feature
shell/gpdf.c uses GTK 2.3 feature
Status: RESOLVED FIXED
Product: gpdf
Classification: Deprecated
Component: general
unspecified
Other Linux
: Immediate major
: ---
Assigned To: Martin Kretzschmar
Martin Kretzschmar
Depends on:
Blocks:
 
 
Reported: 2004-02-06 22:46 UTC by Adam Sampson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to use GTK+ 2.2 function instead of the GTK+ 2.3 equivalent (523 bytes, patch)
2004-02-06 22:49 UTC, Adam Sampson 		none Details | Review

Description Adam Sampson 2004-02-06 22:46:30 UTC 
I've just been building the GNOME 2.4.2 desktop release, which includes
GTK+ 2.2.4 and gpdf 0.112.

gpdf fails to compile because the function set_window_icon_default in
shell/gpdf.c uses gtk_window_set_default_icon, which wasn't added to GTK+
until 2.3.0. This makes gpdf impossible to build in the desktop release,
which seems a bit odd.

The fix appears to be to make set_window_icon_default use
gtk_window_set_default_icon_list instead, since that does exist in GTK+ 2.2.4.
Comment 1 Adam Sampson 2004-02-06 22:49:29 UTC 
Created attachment 24165 [details] [review]
Patch to use GTK+ 2.2 function instead of the GTK+ 2.3 equivalent
Comment 2 Elijah Newren 2004-02-07 01:18:16 UTC 
Prevents building->immediate priority.  I'm adding the patch keyword
and the bugsquad keywords as well.
Comment 3 Martin Kretzschmar 2004-02-07 10:03:48 UTC 
Confirmed, I'm sorry about that silliness.

Was already fixed with gpdf 0.112.1.