After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 133490 - CRITICAL message at start-up while parsing plug_in_rc
CRITICAL message at start-up while parsing plug_in_rc
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: 2.0
Assigned To: GIMP Bugs
GIMP Bugs
: 133480 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-02-05 11:51 UTC by Dave Neary
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to clear error after a first pass doesn't find any file (694 bytes, patch)
2004-02-05 11:55 UTC, Dave Neary 		none Details | Review

Description Dave Neary 2004-02-05 11:51:58 UTC 
Hi,

When I deleted my ~/.gimp-1.3 this morning to do a test, and started up the
GIMP, I got this message:
 
(gimp-1.3:8859): Gimp-Config-CRITICAL **: file gimpconfigwriter.c: line 96
(gimp_config_writer_new_file): assertion 'error == NULL || *error == NULL'
failed
GIMP: Could not open '/home/dave/.gimp-1.3/pluginrc' for reading: No such
file or directory.

After digging about it turns out that gimp_scanner_new_file() returns NULL
if it fails to find a scanner (which is reasonable), and sets the GError
appropriately, but then plug_in_rc_parse() returns TRUE (success) and
doesn't reset the error, so the assertion fails a little further on in
plug_ins_init() (which is where we find it).

I'm opening a bug because I'm not sure about the patch, and someone else I
asked has been unable to reproduce the error.

Dave.
Comment 1 Dave Neary 2004-02-05 11:55:26 UTC 
Created attachment 24089 [details] [review]
Patch to clear error after a first pass doesn't find any file
Comment 2 Dave Neary 2004-02-05 12:14:54 UTC 
*** Bug 133480 has been marked as a duplicate of this bug. ***
Comment 3 Dave Neary 2004-02-05 12:16:31 UTC 
bug confirmed by reporter of duplicate, I'll commit later.

Dave.
Comment 4 Sven Neumann 2004-02-05 12:39:44 UTC 
Please see my comments on bug #133480 and redo your patch accordingly.
Comment 5 Dave Neary 2004-02-06 14:51:37 UTC 
Putting this on the 2.0 milestone. This might get done today, but it
might not. I'm pretty busy.

Dave.
Comment 6 Sven Neumann 2004-02-08 18:49:27 UTC 
Since Bolsh said that he's away for a week, I've committed a fix to
CVS instead:

2004-02-08  Sven Neumann  <sven@gimp.org>

   * app/plug-in/plug-in-rc.c (plug_in_rc_parse): return FALSE if the
   file wasn't found.

   * app/plug-in/plug-ins.c (plug_ins_init): don't output the error
   message from plug_in_rc_parse() if it failed for file not found.

   Fixes bug #133490.