After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132902 - theme install button uses old GtkFileSel instead of GtkFileChooser
theme install button uses old GtkFileSel instead of GtkFileChooser
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
git master
Other Linux
: High normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 136029 (view as bug list)
Depends on:
Blocks: 129568
Reported: 2004-01-29 20:44 UTC by Seth Nickell
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target:
GNOME version: ---

Patch for using GtkFileChooser in the Entry (1.15 KB, patch)
2004-02-25 16:13 UTC, Fernando Herrera
none Details | Review

Description Seth Nickell 2004-01-29 20:44:29 UTC
It would be nice to switch as completely as possible over to the new file
chooser for GNOME 2.6 so we don't have mixed widgets.
Comment 1 Simon Porter 2004-02-05 16:48:18 UTC
Thanks for the reminder. I would expect the whole of the Gnome desktop
will be moving over to this as soon as possible.

Notes: Changed severity to enhancement, added bugsquad keyword
Comment 2 Luis Villa 2004-02-05 16:50:32 UTC
I'm adding the TARGET 2.6.0 keyword as well- we should not ship GNOME
2.6 with this in.
Comment 3 Fernando Herrera 2004-02-25 16:12:41 UTC
One line patch. Okey to commit?
Comment 4 Fernando Herrera 2004-02-25 16:13:56 UTC
Created attachment 24767 [details] [review]
Patch for using GtkFileChooser in the Entry
Comment 5 Seth Nickell 2004-02-29 23:57:47 UTC
Luis? Do we need RT approval at this point or is it clear by virtue of
being a UI-REVIEW bug?
Comment 6 Andrew Sobala 2004-03-01 01:05:03 UTC
It still needs maintainer approval. Since we're in UI-freeze it's
probably best to run it past the release team - but we'll almost
certainly quickly rubber stamp it as OK.
Comment 7 Luis Villa 2004-03-01 22:17:33 UTC
Sorry, definitely not needed (well, like Andrew said we'd rubber stamp
anyway.) Seth, Jody, please commit.
Comment 8 Jody Goldberg 2004-03-02 14:44:53 UTC
blah, just getting to the theme capplet now.  Apologies for the delay.

Patch is trivial and has been applied.   All it's doing is telling
libgnomeui to use the file chooser (why isn't that the default now)
Comment 9 Fernando Herrera 2004-03-02 14:58:58 UTC
It's not default because GnomeFileEntry exposed the old
GtkFileSelection widget in its public API, so if we make it default we
can broke some apps. So we need to check app by app and set it
manually if the app is not accessing fentry->fsw
Comment 10 Carlos Romero 2004-03-03 11:18:43 UTC
*** Bug 136029 has been marked as a duplicate of this bug. ***