After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132610 - contents-changed signal not useful due to a typo
contents-changed signal not useful due to a typo
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other All
: High normal
: ---
Assigned To: VTE Maintainers
Nalin Dahyabhai
Depends on:
Blocks: 132173
 
 
Reported: 2004-01-26 23:11 UTC by Mariano Suárez-Alvarez
Modified: 2005-08-15 01:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix the typo and make contents-changed work (700 bytes, patch)
2004-01-26 23:16 UTC, Mariano Suárez-Alvarez 		none Details | Review

Description Mariano Suárez-Alvarez 2004-01-26 23:11:03 UTC 
There is a typo in vte.c, corrected by the following patch, which renders
the contents-changed signal not very useful, and blocks bug 132173, for
example.
Comment 1 Mariano Suárez-Alvarez 2004-01-26 23:16:01 UTC 
Created attachment 23785 [details] [review]
fix the typo and make contents-changed work
Comment 2 Mariano Suárez-Alvarez 2004-01-26 23:17:40 UTC 
Can I commit this, nalin?
Comment 3 alexander.winston 2004-02-18 17:08:05 UTC 
Upgrading the priority to high and adding the PATCH keyword because of
Mariano's patch.
Comment 4 Nalin Dahyabhai 2004-04-20 05:47:34 UTC 
Supplied patch didn't compile.  Guessing it meant to call
vte_terminal_emit_contents_changed() after vte_terminal_match_contents_clear(),
instead of replacing the call to vte_terminal_match_contents_clear() with a call
to non-existent vte_terminal_match_contents_changed().

Please reopen this if I got part of this wrong.  Thanks!