GNOME Bugzilla – Bug 132515
'Delete' should have a shortcut key
Last modified: 2018-05-24 10:29:28 UTC
I thought 'Delete' (remove from library) was supposed to have a shortcut key, i.e. the Delete key. 0.6.5 doesn't have this. Please add. ('Cut' works in playlists, but not in the library.)
Will have a look into the issue. Assigning to myself.
I would second the delete key to remove the track from Rhythmbox (ie: from a playlist if your are in one, from the library if viewing the library).
*** Bug 312000 has been marked as a duplicate of this bug. ***
I guess this bug could be marked as resolved?
With CVS, I can't press "Delete" or "Backspace" to delete songs from the library.
You can use ctrl+t to delete, which is the Nautilus keybinding. I asked a similar question on the mailinglist, and the reply was, that Rhythmbox wants to follow the Nautilus keybindings.
(nautilus permits Delete here)
My take: Ctrl+T means "move to Trash", not "Delete". If rhythmbox moves deleted songs to the trash, then Ctrl+T is correct, otherwise it should be the Delete key.
I second the call for a shortcut key to remove from playlist/library/current context, preferably the "Delete" key. I don't like making the mouse or menu-lists mandatory, which seems to be the current situation. Ctrl-T actually deletes the song from the disk, not from a list (I tried this and, unfortunately, it didn't even send it to the trash--it simply erased it, but that's another bug).
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Ubuntu bug about that: https://launchpad.net/distros/ubuntu/+source/rhythmbox/+bug/43499 "At present, if you want to delete a song from the queued songs list, you would have to left click it, right click, then press remove. It would be a lot easier to click it then press delete on your keyboard."
*** Bug 374362 has been marked as a duplicate of this bug. ***
You can set the shortcut on the menus with GTK+'s editable menu accelerators, but for me (YMMV) the accelerators are not remembered the next time I start Rhythmbox.
*** Bug 440484 has been marked as a duplicate of this bug. ***
This is a usability bug. I don't get why it can't be fixed. It's three years old. Please Jonathan fix it. It shouldn't take more than five minutes. Thanks and regards
*** Bug 497004 has been marked as a duplicate of this bug. ***
*** Bug 533843 has been marked as a duplicate of this bug. ***
Bug: - 4.5 years old - 6 duplicates (including the one from ubuntu) - No workaround because you can't assign shortcut via menu accelerators (at least i couldn't) Could the users get some feedback? Do the developers have no time to implement it, are you still unsure how to implement it the right way or have you just decided to leave it as it is?
5.5 Year old bug and it still bugs me... Why can't I use 'Delete' in the queue? It's the one button on the keyboard that means to remove something. I want to remove the song from the queue but I can't use the assigned key to do that. Instead I have to reach for my mouse and right click and select Remove.
Created attachment 165636 [details] [review] Add 'Delete' key binding for 'remove from playlist' menu item. It seems that this key binding was removed to prevent accidental removing tracks with pressing delete key in search box. Another problem is that if you have selected songs both in the library and in the side bar queue than selecting 'Remove' from edit menu will selected tracks from queue and from the library. So I made a small patch that gives back 'Delete' shortcut to the 'Remove from playlist' menu item.
I was wrong. With this patch and queue in sidebar rhythmbox doesn't remove selected songs both from library and playlist. It removes only from library and if some of the deleted songs are in queue they are deleted from there too. It's OK. But there is still a problem. When you switch from any playlist to the library 'Remove from playlist' menu item is removed from the edit menu but corresponding action is not disabled. So if you add 'Delete' key binding to this action pressing 'Delete' triggers this action even in library (not only in playlist or queue) and calls remove_from_playlist_cmd (that is in rb-playlist-source.c). As the result with this patch pressing 'Delete' removes song from the library that is really unexpected. I think the problem is that remove_from_playlist_cmd works in the same way for any source type. Should I add source type check to this function to perform deletion only for playlists, but not for library? And about usability. This key binding was removed by commit 3baff08252c01cc697d4ba3a6dc926248787f007. I think it'll be OK if rhythmbox don't have key binding for removing file from library, because you rarely remove tracks from library. On the other hand managing playlists and play queue is often action and removing tracks from them via menu is awful. And I think it'll be nice to add 'Delete' key binding just for playlists and play queue, but there some problems and I'll be grateful if someone helps to solve them.
Kirill: I think this will be great. Can it be made to work like this; If the library is in focus and Delete is pressed, a pop-up notification will ask "Do you really want to remove this item from the library?" (DO NOT remove this from the disk under any circumstances). Just remove it from the library and let rhythmbox detect it again on next restart. If the queue is focused, delete should remove the selected song and select the next one in the list. No questions asked.
Yeah, sounds good. But I'm still not very familiar with rhythmbox infrastructure and remove_from_playlist_cmd function seems a little bit strange to me. It should work only for playlists, but works for any source type. And this circumstance makes some troubles for me. So I'm afraid that I'm not able to perform a good enough patch that implements your idea right now. The problem (for me, as for junior rhythmbox developer =))is to detect the active source (library/playlist/queue).
Kirill: I hope you didn't stop working on the patch? I'm sure you could get some help of the rhythmbox dev-list, no?
I see this bug has (quite obviously) already been reported. I'm surprised it still isn't possible to use the delete key to remove a song (or several) from the playlist. Please, pretty please, fix this. It just makes sense that del would remove a song from the playlist. For the music library, the expected behaviour is more debatable. Thanks to everyone working on Rhythmbox! :)
I agree: it's time to fix this bug. I'd suggest that the shortcut be Ctrl+Delete, since that's the shortcut used for deleting files in Nautilus in GNOME 3 (and is unlikely to be typed by mistake, unlike Delete).
*** Bug 420733 has been marked as a duplicate of this bug. ***
*** Bug 617656 has been marked as a duplicate of this bug. ***
Has there been any more thought on this?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/26.