After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132018 - Glade files found using ephy_file()
Glade files found using ephy_file()
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2004-01-20 19:08 UTC by Adam Hooper
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6

Attachments
Proposed patch (7.55 KB, patch)
2004-01-20 19:11 UTC, Adam Hooper 		none Details | Review
Patch #2 (9.52 KB, patch)
2004-01-21 13:03 UTC, Adam Hooper 		none Details | Review

Description Adam Hooper 2004-01-20 19:08:02 UTC 
Instead of finding .glade files using ephy_file() (which doesn't allow
extensions to open .glade files from arbitrary paths), the paths can be
explicitly written in every call to ephy_dialog_construct () (and in
GtkNSSDialogs.cpp).

I've attached a patch which changes ephy_file(), ephy_glade_widget_new(),
all (I hope) callers to ephy_dialog_construct (), and GtkNSSDialogs.cpp.
Comment 1 Adam Hooper 2004-01-20 19:11:45 UTC 
Created attachment 23567 [details] [review]
Proposed patch
Comment 2 Marco Pesenti Gritti 2004-01-21 08:26:20 UTC 
+                               SHARE_DIR "/glade/epiphany.glade"

I think this should be

ephy_file ("epiphany.glade");

and so for all the others. Any reason not to do it this way ?
Comment 3 Adam Hooper 2004-01-21 13:03:32 UTC 
Created attachment 23596 [details] [review]
Patch #2
Comment 4 Marco Pesenti Gritti 2004-01-21 19:00:40 UTC 
Looks good. You have unnecessary/unrelated changes in ephy-shell and
ephy-file-helpers. Please remove these and commit. Thanks !
Comment 5 Christian Persch 2004-01-21 20:39:37 UTC 
Fixed in cvs.