GNOME Bugzilla – Bug 131045
Output to syslog
Last modified: 2004-12-22 21:47:04 UTC
Attached is a patch to make bonobo-activation and activation-server output messages to syslog. In addition, I removed some FIXME code that looked related and changed some message calls to fit the new code. This feature was requested in bug 90983.
Created attachment 23183 [details] [review] Proposed patch
This is a nice patch; can you re-hash it a little before re-diffing and committing to HEAD though? a) we want to avoid churning stuff to syslog in the common case - since that makes everything very slow (sync. disk access there). I'm not convinced that we arn't unconditionally churning debug to syslog; we need a 'output debug messages' type setting a-la gconf to control that. b) We don't want the g_log trapping stuff in the bonobo-activation client-side code, only for the server IMHO. c) We should acknowledge Havoc's copyright on the syslog stuff - since this is cut/paste from gconf. Apart from that: looks great :-) Many thanks for this.
Created attachment 23278 [details] [review] Revised patch
This revised patch removes the client changes (bonobo-activation/*), includes a ChangeLog entry which, among other things, notes the inspiration from GEdit (though this is not a simple cut/paste), and respects the environment variable BONOBO_ACTIVATION_DEBUG_OUTPUT. It only outputs debug messages to syslog if it is compiled for debugging AND that environment variable is defined. Comments? I cannot check this in, so if you find it suitable, please do so for me.
Created attachment 23284 [details] [review] Revised patch with missing ChangeLog changes
Checked this in a while back - thanks.