After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 129872 - GtkFileSystemUnix should support bookmarks
GtkFileSystemUnix should support bookmarks
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.3.x
Other Linux
: High major
: ---
Assigned To: Federico Mena Quintero
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2003-12-22 23:45 UTC by Jan Arne Petersen
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implements the simple bookmarks support. (Propably there is not enough error checking in the I/O methods). (5.48 KB, patch)
2003-12-23 00:00 UTC, Jan Arne Petersen
none Details | Review

Description Jan Arne Petersen 2003-12-22 23:45:54 UTC
GtkFileSystemUnix should support a simple $HOME/.gtk-bookmarks file.
Comment 1 Jan Arne Petersen 2003-12-23 00:00:48 UTC
Created attachment 22657 [details] [review]
Implements the simple bookmarks support. (Propably there is not enough error checking in the I/O methods).
Comment 2 Federico Mena Quintero 2003-12-31 03:58:58 UTC
Some comments on the patch:

- It should have error checking in the I/O functions.

- It would be good to write the bookmarks to a temporary file and then
do an atomic rename() to the final file.  Gedit has example code for
this, and I believe libgsf does, too.

- As a minor issue, rather than g_list_append(), use g_list_prepend()
and then g_list_reverse() when you are done building the list.  This
is O(N) versus O(N^2).

Thanks for working on this, Jan Arne :)
Comment 3 Federico Mena Quintero 2004-01-30 18:03:45 UTC
Thanks a lot for the patch, Jan Arne.  I have made a few changes and
committed it to CVS.