GNOME Bugzilla – Bug 129872
GtkFileSystemUnix should support bookmarks
Last modified: 2011-02-04 16:16:03 UTC
GtkFileSystemUnix should support a simple $HOME/.gtk-bookmarks file.
Created attachment 22657 [details] [review] Implements the simple bookmarks support. (Propably there is not enough error checking in the I/O methods).
Some comments on the patch: - It should have error checking in the I/O functions. - It would be good to write the bookmarks to a temporary file and then do an atomic rename() to the final file. Gedit has example code for this, and I believe libgsf does, too. - As a minor issue, rather than g_list_append(), use g_list_prepend() and then g_list_reverse() when you are done building the list. This is O(N) versus O(N^2). Thanks for working on this, Jan Arne :)
Thanks a lot for the patch, Jan Arne. I have made a few changes and committed it to CVS.