GNOME Bugzilla – Bug 129608
GOK UI Grab not listing all options on Theme Preferences application
Last modified: 2004-12-22 21:47:04 UTC
Using GOK from CVS HEAD 16 Dec 2003 -Using GOK, start up the Theme Preferences (Applications -> Desktop Preferences -> Theme) -Select the Large Print theme -Notice an 'Apply Font' button becomes active with this theme option -On GOK, select 'UI Grab' -The 'Apply Font' button is not listed GOK doesn't recognise this button and it isn't given to the user as an option.
It looks like not notiifcation is emitted when the Apply Font button is appears. I will investigate further.
When the Apply Font button appears the page-tab containing the button is selected and the previous page-tab one is deselected. I suspect that gok does not update its UI when this happens.
that's not the problem AFAICT; even if you go back to the GOK main kbd and UI Grab the new dialog, this button is invisible. It seems that GOK is not traversing into the page tab list for some reason. GOK does have facility for listening to certain kinds of page-tab events.
I don't think this belongs on the UI Grab tracker, since it's about support for more kinds of objects. That's not the root issue with this bug, the root issue has to do with reacting to different kinds of notifications differently.
Bill, I've had another look at your major gok-spy refactor work. (I notice there is almost no recursion anymore) I'm trying to get a clearer picture of the gok_spy_search_component_list function. In particular there is a page-tab special case in the toolbar section... Can you tell me if I'm getting warm, or heading in the wrong direction here? This is an odd, but disturbing bug.
I am not sure this is closely related to the page-tab special-case (though it's worth a glance). Note that the PAGE_TAB case just ensures that children of the (actionable) page-tab are searched for interesting UI components, by recursing. I am not sure what you mean about "almost no recursion" since I think recursion is more common than not, when gok_spy_search_component_list executes.
Sorry, a parsing error (human).
Bill, I'm just wondering about your earlier comment: "It seems that GOK is not traversing into the page tab list for some reason" GOK seemes to be listing everything on the page except for that one button to apply the font... for me at least.
right, that comment is probably inaccurate. What does at-poke show, for the states/role of the button that's not showing up? Can we confirm that GOK doesn't see the "extra" button even if we move focus away from the dialog (to another accessible window) and back?
I can confirm that is the case. OK, I took a another look at the GUI tree using at-poke, and I now think your comment is very relevant. There is a page tab list that contains that button, and GOK is not showing anything in that page tab list (there is only one relevant component: the apply font button)... heading to IRC...
This look like a possible gail issue. Bill and Padraig will take a closer look.
Created attachment 28205 [details] [review] Proposed gail patch Does the proposed gail patch fix the gok problem?
Padraig: patch fixes the problem. Transferring to gail.
Patch committed to CVS HEAD.