GNOME Bugzilla – Bug 129073
Right click on "panel menu button" should have "Browse Applications" option.
Last modified: 2015-03-24 13:00:45 UTC
Right click on panel menu button has "Help", "Remove From Panel", "Lock/Unlock" and "Move". It would look better to have an option like "Browse Application", on click which lauches a nautilus window. 'Browse Application' should launch nautilus window with applications:///
Created attachment 22328 [details] [review] Patch adds the feature mentioned.
I'm adding the usability people to CC so they can give their advice about this feature. I think this is ok, but maybe they have a better plan about this. I looked a bit at this patch. egg_screen_execute_command_line_async (screen, "nautilus applications:///", &error); One problem is that there can be menu buttons for all the directories in applications:///. E.g.: open the application menu, go to internet and right-click. There you can choose to add this subdirectory as a menu button to the panel. And so, when you browse this menu button, you should browse applications://internet/ (see the menu_path field of the menu button structure). You may want to launch 'nautilus --no-desktop' too.
Actually, you probably really want to do: gnome_url_show_on_screen (screen, button->menu_path, &error); Also curious to see what the usability people think, but it does seem like a good entry point for editing the menu.
Created attachment 22510 [details] [review] Patch fixes the bug.
*** Bug 130665 has been marked as a duplicate of this bug. ***
bizarre that we have a different patch in JDS. god bless communication ;)
One small comment on this patch: in panel-menu-button.c: + panel_applet_add_callback (info, "browse", NULL, _("_Browse Applications")); + This should be "Browse %s" where %s is the name of the folder. Problem is that we don't have access to the name of the folder in the struct _PanelMenuButtonPrivate.
Patch looks pretty reasonable to me. Still need input from usability people. + Punting to 2.8. We're past the UI freeze. panel_menu_bar_invoke_menu (PanelMenuBar *menubar, const char *callback_name) { GdkScreen *screen; + GError *error = NULL; + "error" is not use at this scope, move it into the browse handling scope + } else + return; +} + Delete this - its completely unneccessary. + panel_applet_add_callback (info, "browse", NULL, _("_Browse .... + As Vincent said, in panel-menu-button.c you should use the actual name of the menu + Make the same changes in panel_menu_button_invoke_menu() that I suggest above
I think it's a harmless feature that gives us some consistency with Windows, although Windows has separate entries for "Open" and "Open All Users"... should we do the same, opening applications:/// and applications-all-users:/// respectively? Also need to be careful with terminology now that we have spatial Nautilus-- "Browse" implies opening a navigational rather than spatial window, is that what this patch does? If not, we should probably use "_Open" IMHO (as "Open Applications" would be a bit ambiguous), or even "_Edit" if we were feeling keen :)
*** Bug 102898 has been marked as a duplicate of this bug. ***
Created attachment 25800 [details] [review] Patch with above mentioned feature.
Created attachment 25802 [details] Attaching screenshot for Edit Menus :)
Hmm, I'm not sure that "Edit" should be a submenu, I was just suggesting it as an alernative term for "Open" or "Browse". I suppose it might be useful, but it feels a bit like overkill for a feature most people will never see.
The initial patch looked fine to me (GUI-wise), however I believe Bala already wrote one for JDS that does the same thing, so we should probably post that one here instead :)
Calum: Basically my *initial* patch in bugzilla and bala's patch in JDS are same. The patch was first put into bugzilla and later it was applied into JDS :-). Mark, Vincent: Shall i commit my initial patch into CVS HEAD?
*** Bug 154905 has been marked as a duplicate of this bug. ***
I'm sorry this patch never got accepted. Problem now is that applications:/// is no longer used for the panel. We'll need to figure out a menu editing solution, and as part of that we'll probably have a menu item like this, but I think for now its better to just close this. Thanks
Now we should link the thing to gmenu-simple-editor
2005-05-18 Mark McLoughlin <mark@skynet.ie> Add an "Edit Menus" menu item to the menu bar and menu button context menu. Based on a patch from Vijaykumar Patwari <vijaykumar.patwari@wipro.com> in bug #129073. * panel-menu-bar.c: (panel_menu_bar_load): add an "Edit Menus" context menu if gmenu-simple-editor is installed. (panel_menu_bar_invoke_menu): Run gmenu-simple-editor if Edit Menus is clicked. * panel-menu-button.c: (panel_menu_button_load), (panel_menu_button_invoke_menu): ditto here.