GNOME Bugzilla – Bug 128452
Compilation fails because of coding error in xdap
Last modified: 2004-12-22 21:47:04 UTC
xdap.c line 162 struct assignement does not work this way...
Created attachment 22059 [details] [review] Fixing the struct copy
I'm not an XDAP expert, but I think that this fix is not the correct one. If you are using GNOME 2.5, you should try CVS of GnomeMeeting which contains the proper fix... Mark this bug as fixed if CVS works. CVS will enter the GNOME beta's soon.
*** Bug 125745 has been marked as a duplicate of this bug. ***
Well if CVS HEAD uses something like xmlSAXHandler sax = xmlDefaultSAXHandler' you will still have a problem... That's a structure and you can't copy a structure that way, at least not with my compiler :)
the type of the xmlDefaultSaxHandler has changed libxml 2.6. xmlDefaultSaxHandlerV1 (iirc) has been introduced for compatibility. That's what we are using in CVS. So we are doing an equal for 2 structures of the same type, and it works.
Well i guess struct copy is tolerated this way struct foo, bar; foo = bar; but i still think it's better to have memcpy (&foo, &bar, sizeof(bar));
yes I agree, that's what I'm doing when it is my own code actually. Paul is in the process of reworking XDAP, so I forwarded this bug report to him.
Fixed in 1.0, sorry for not closing.