After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 128452 - Compilation fails because of coding error in xdap
Compilation fails because of coding error in xdap
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: general
0.98.5
Other Linux
: Normal normal
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
: 125745 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-12-03 16:05 UTC by Julien MOUTTE
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixing the struct copy (638 bytes, patch)
2003-12-03 16:08 UTC, Julien MOUTTE
none Details | Review

Description Julien MOUTTE 2003-12-03 16:05:48 UTC
xdap.c line 162 struct assignement does not work this way...
Comment 1 Julien MOUTTE 2003-12-03 16:08:09 UTC
Created attachment 22059 [details] [review]
Fixing the struct copy
Comment 2 Damien Sandras 2003-12-03 16:34:22 UTC
I'm not an XDAP expert, but I think that this fix is not the correct
one. If you are using GNOME 2.5, you should try CVS of GnomeMeeting
which contains the proper fix...

Mark this bug as fixed if CVS works. CVS will enter the GNOME beta's soon.
Comment 3 Julien MOUTTE 2003-12-03 16:37:44 UTC
*** Bug 125745 has been marked as a duplicate of this bug. ***
Comment 4 Julien MOUTTE 2003-12-03 16:40:39 UTC
Well if CVS HEAD uses something like 

xmlSAXHandler sax = xmlDefaultSAXHandler'

you will still have a problem... 

That's a structure and you can't copy a structure that way, at least
not with my compiler :)
Comment 5 Damien Sandras 2003-12-03 16:43:13 UTC
the type of the xmlDefaultSaxHandler has changed libxml 2.6.
xmlDefaultSaxHandlerV1 (iirc) has been introduced for compatibility.
That's what we are using in CVS. So we are doing an equal for 2
structures of the same type, and it works.
Comment 6 Julien MOUTTE 2003-12-03 16:51:42 UTC
Well i guess struct copy is tolerated this way 

struct foo, bar;

foo = bar;

but i still think it's better to have 

memcpy (&foo, &bar, sizeof(bar));
Comment 7 Damien Sandras 2003-12-03 17:57:12 UTC
yes I agree, that's what I'm doing when it is my own code actually.
Paul is in the process of reworking XDAP, so I forwarded this bug
report to him.
Comment 8 Damien Sandras 2004-10-14 10:53:25 UTC
Fixed in 1.0, sorry for not closing.