GNOME Bugzilla – Bug 128346
The calendar doesn't indicate current date
Last modified: 2018-05-02 13:54:55 UTC
There doesn't seem to be any indication in the calendar what the current date is. There should be something like the little red rectangle in evolution calendar to highlight the current date.
Yeah, that would be nice. Maybe you can query for the folks working on evo<->clock applet integration, and suggest that they add it in their patches?
I don't think the GTK calendar widget can handle this (it can not handle two different set of marks, AFAIK).
Isn't this fixed now with the evolution integration?
Marc: AFAIK, no.
Created attachment 28896 [details] [review] The FIx
The patch is for GTK+. Moving to GTK+ to see if GTK+ hackers are interested in such a feature.
Patch seems wrong, it simply fixes the initially selected day and always draws that insensitive, like days outside the month. This a) isn't the right way to indicate the current date. Something else, eg the red border would be better b) the current day should only be highlighted in the current month, not in all months c) won't work if the app runs for more than a day, since the current_day is never updated
I aggree that the red border is a good idea. But is hard-coding a colour (red) a bad thing? I have never looked at GTK themeing before, but on quick inspection I see that there are some colours specified in a theme's gtkrc file: bg[NORMAL] = "#ffffff" bg[PRELIGHT] = "#ffffff" bg[ACTIVE] = "#ffffff" bg[INSENSITIVE] = "#ffffff" bg[SELECTED] = "#1376d3" base[NORMAL] = "#ffffff" base[SELECTED] = "#1376d3" base[ACTIVE] = "#5e7ab7" text[SELECTED] = "#ffffff" text[ACTIVE] = "#ffffff" Would it be better to use one of these colours rather than red to draw a border around today?
The color should be determined by a style property, see how the icon view handles its rubberbanding color. Also, there should be a regular boolean property to turn this feature on, defaulting to FALSE.
While looking through the list of usability booogs I stumbled onto this one. Is anyone looking into this still, it would be nice to aim to fix it before the 2.10 release. Perhaps instead of simply coloring the sqaure for the current day, we could also use some sort of visual shape queue? We seem to only box it now with a color from the theme like so: 1 2 3 [ 4 ] where the square is filled with a color. Perhaps could we do something like little arrows for the current day. 1 2 3 |> 4<| where the arrows are filled with a color of distinction. I am inclined to think using some distinct shape for marking the current day in conjunction with a distinctive color might help in case of users with issues discerning colors.
Matthias: Why would you want to add the ability to turn this feature on or off? Indicating the current date is a core feature of a calendar, and I cannot imagine why anyone would not want this feature.
Because existing users of GtkCalendar might not want this new feature.
Ah, I understand now. I didn't realise that it was a shared componant.
*** Bug 518124 has been marked as a duplicate of this bug. ***
*** Bug 518126 has been marked as a duplicate of this bug. ***
Created attachment 224960 [details] [review] Facility to optionally draw a frame around the current date This patch adds a "mark-today" property to GtkCalendar. If set, it will cause the calendar to draw a frame around the current date in the foreground color. This uses Cairo directly to do the painting. Alternatively one could use gtk_render_frame but I am not entirely sure as to how I should approach the issue that way. Currently I have the impression that it would require adding a new class to gtk-default.css and to the GtkStyleContext.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/230.