After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 127464 - Disconnecting leaves groupchats dangling.
Disconnecting leaves groupchats dangling.
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: Group Chat
unspecified
Other other
: Normal normal
: 0.8
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on: 157841
Blocks:
 
 
Reported: 2003-11-20 10:37 UTC by Ralph Meijer
Modified: 2005-05-05 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes this bug. (3.57 KB, patch)
2005-05-04 20:38 UTC, Martyn Russell
none Details | Review

Description Ralph Meijer 2003-11-20 10:37:29 UTC
When disconnecting, none of the chats get an indication of this. This is
especially irritating for groupchats, since you don't get joined again when
reconnecting the client.

It would be nice to have a visual indication in the open chat windows that
the client is disconnected. Maybe a gray message like the message time stamps.

Also, rejoining open group chats should be done. Otherwise you get
'Forbidden' error messages, without any other explaination.
Comment 1 Geert-Jan Van den Bogaerde 2004-01-06 21:57:15 UTC
Regular chats now get a disconnected event message, I haven't
implemented this for groupchat yet though.
Comment 2 Richard Hult 2004-01-23 10:54:51 UTC
Changing summary to reflect the bug.
Comment 3 Martyn Russell 2005-05-04 20:38:05 UTC
Created attachment 46032 [details] [review]
Fixes this bug.

This now has the same action as connecting/disconnecting in a normal chat
window, but for group chats.

Plus, there was a "disconnected" signal being emitted twice because it was done
when we disconnect manually AND when we get called back from Loudmouth that the
connection has closed.	I have fixed that.

The "connected" event wasn't being caught for standard chat sessions because
only "protocol-connected" was being emitted.  Fixed that too.
Comment 4 Mikael Hallendal 2005-05-05 13:08:42 UTC
Tweaked the code in gossip-session.c some and commited.

Thanks.