GNOME Bugzilla – Bug 126518
flipping support in GtkComboBox
Last modified: 2011-02-04 16:16:03 UTC
isn't really there, which is a regression against GtkOptionMenu where I fixed this stuff for 2.2.
Created attachment 22200 [details] [review] patch to flip the new combo box
The patch moves the arrow to the other side in RTL mode and changes the positioning of the popup. For complete flipping, you need the patch from bug 128348 to flip the cellview.
Created attachment 22212 [details] A capture image to show the issue which remains
A problem still remains in the patch(id=22200). When we use gtkcombobox in Windows-style, the width of "cell_view_frame" should be increased. You can find the problem from the image I attached last comment. (Please gaze at the left edge of popup window.) The steps to see the image is here. 1. Change appearance of combo boxes to Windows-style. Currently I see only one possibility to do this: install "appearance" style property of GtkComboBox with value "TRUE" (file gtkcombobox.c, gtk_combo_box_class_init() ). 2. Run testcombo in bidi locale. Semion Chichelnitsky<semion@il.ibm.com> created another patch. It includes the patch (id=22200). I'll attach his patch to the next comment. Could you try it? Thank you,
Excuse me. Please gaze at the right edge of popup window (not left).
Created attachment 22213 [details] [review] Another proposed patch (Based on CVS 2003/Dec/08)
In Windows-style, you can also find another problem with pressing the popup button of GtkComboBox Entry of testcombo program. As the initial point of popup window is on the left, you cannot see some elements. The patch for Bug #127581 is effective for this problem. Thanks you,
Both of the remaining problems described by you are just the treeview not setting its initial scroll position properly in rtl mode. You already proposed a patch for that in bug 127581, and it works nicely to fix the issues here.
The little problem with width of cell_view_frame can't be fixed by patch 127581 - it siply can remain imperceptible. Screen shots from attachment 22212 [details] are received without this patch to demonstrate problem using testcombo application. You can compare width of frame, created for GtkComboBox with other one, which is created for GtkComboBoxEntry. See also gtk_combo_box_size_request(), where full width (in case when cell_view_farme is used) includes width of two cell_view_frame's borders and two xthickness. As far as I understand, it is exacltly what should be added to width of corresponding frame.
Thats what I meant, it will be "fixed" in the sense that it will be just as invisible as it is in the LTR case.
Committed on HEAD.