After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 126167 - when opening a webpage from the commandline that has a bad url put the bad url into the address entry anyway
when opening a webpage from the commandline that has a bad url put the bad ur...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
1.1.x
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on: 119047
Blocks: 147840
 
 
Reported: 2003-11-04 09:38 UTC by Dave Bordoley [Not Reading Bug Mail]
Modified: 2005-08-01 21:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dave Bordoley [Not Reading Bug Mail] 2003-11-04 09:38:47 UTC
ok so this is pretty low priority dave crack...
anyway so i basically only open web pages via open applet which calls
"epiphany uri://" via url_show_blah_blah...only problem is sometime i miss
type and a ephy window opens as expected, popsup an error dialog, but
doesn't put the bad uri into the address entry (it puts about:blank) so i
cannot correct it. Therfore i have to rewrite the whole thing, potentially
making the same mistake again.

I'm pretty sure i'm the only user who has this issue, but could you pretty
please fix it :)
Comment 1 Marco Pesenti Gritti 2003-11-04 10:24:06 UTC
Chpe, this involve to solve the address api problem.
What we have now is:

gresult
ephy_embed_get_location (EphyEmbed *embed,
                         gboolean toplevel,
                         char **location);

What about:

enum
{
    EMBED_ADDRESS_SOURCE_TOPLEVEL_DOCUMENT
    EMBED_ADDRESS_SOURCE_FOCUSED_DOCUMENT,
    EMBED_ADDRESS_SOURCE_NAVIGATION
} EphyEmbedAddressSource;

gresult
ephy_embed_get_address (EphyEmbed *embed,
                        EmbedAddressSource source,
                        char **location);

Hrm just figured out this is prolly not enough, but anyway while I
typed it ... what do you think ?

I dont get what's the real problem here. In location we pass the gtk
moz embed location, which should be set to url we tried to load ...
Comment 2 Marco Pesenti Gritti 2003-11-04 10:37:19 UTC
So the events are emitted in this order.

open_uri_cb http://gnome.org/
load_started_cb
location_changed_cb

We never get to location_changed when load fail.

I think it make sense to keep the old uri if loading fail in general,
otherwise address bar and page goes out of sync.
Though for the first page we could make an exception, about:blank is
not that informative. What do you think ?

To implement it, I guess we should connect open_uri and set it only if
current location is NULL. Need to be considered carefully because the
expire stuff is pretty complex and could break easily.
Comment 3 Christian Persch 2004-10-13 10:54:55 UTC
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Comment 4 Christian Persch 2005-05-23 12:48:09 UTC
I cannot reproduce this in Epiphany HEAD anymore, closing.
Comment 5 Christian Persch 2005-08-01 21:20:44 UTC
Definitely fixed now.