GNOME Bugzilla – Bug 126089
Paste should be insensitive when unavailable
Last modified: 2017-12-22 12:45:49 UTC
Following on from Bug #125342, The Paste button should be insensitive when pasting is not possible. I have a patch which does some of the work, and I'm waiting for Anon CVS to catch up before submitting it. However, the conditions for pasting to be possible are not complete, and should be recalculated when clipboard contents change (this one requires a new signal somewhere)
Do you still have that patch? I suspect that it might no longer be directly applicable as I did a big rewrite of the clipboard handling for 0.7.9 But it'd be worth seeing in any case.
Whoops! I knew there was something in here I still has to do... Looking for that patch now...
Created attachment 23044 [details] [review] Allows control of Paste sensitivty through cong_document_can_paste, which currently always returns TRUE
This patch allows the control of Paste sensitivity through placing calls to a cong_document_can_paste fucntion, which currently returns true. More work to be done: determine the conditions under which Paste should be accessible, and put these into cong_document_can_paste. Also connect certain signals to force the sensitivty to be re-assesed at the correct times. From the developers mailing list You should look at the paste routine and test for all the conditions in which it can fail. Look in src/xmledit.c, in function cong_document_paste_clipboard_or_selection, and potentially in the functions it calls. ... Looking at cong_document_paste_clipboard_or_selection, it looks like it'll be affected by CongDocument "cursor_change", and by whatever signal we can set up to monitor the X clipboard. Have asked Dave on mailing list to look into signals to connect to the X clipboard.
patch applied, when I have a clean compile I will CVS commit
patch now in CVS, also mailinglist informed.
For convenient future reference, here's a link to a copy of the ICCCM, to the part dealing with selection handling in X: http://tronche.com/gui/x/icccm/sec-2.html
Conglomerate is not under active development anymore. It is currently unlikely that there will be any further Conglomerate development. Closing this report as WONTFIX as part of Bugzilla Housekeeping (bug 685689) to reflect reality. Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.