GNOME Bugzilla – Bug 122303
Panel menu tooltips are inaccurate.
Last modified: 2004-12-22 21:47:04 UTC
This can be reproduced as follows: 1. Open the applications menu, navigate to a submenu (say, "System Tools"), and add that submenu to the panel, using the "Add this as menu to panel" option. 2.Hover over the new menu that has been created. The tooltip inexplicably says "Main Menu". Expected behavior: The tooltip should say "System Tools". In other words, it should take the folder name under applications:/// that the menu was created from. It seems like the tip "Main Menu" is hard coded, though, or at least very difficult to change.
Created attachment 20570 [details] [review] Proposed patch.
Here's a patch for this (without the ChangeLog entry as it's not complete). What it does is install and use a property "tooltip" for the panel menu buttons. The tooltip is stored in gconf like for the drawers. There's one thing I'm not sure about : in panel.c, I don't add a tooltip when to the panel menu button when it is created from within drop_menu(). I'm not sure what it should be (I've not looked a lot a this). What do you think ?
Mark/Arvind: can you review the patch?
Mark/Arvind: ping :-)
Sorry about that Vincent - the patch looks good, I'd only change one thing - make it: - const char *menu_path) + MenuFinfo *menu_info) { char *menu_path; gboolean use_menu_path; char *tooltip; if (!menu_info) { menu_path = NULL; use_menu_path = FALSE; tooltip = _("Main Menu"); } else { menu_path = menu_info->menudir; use_menu_path = TRUE; tooltip = menu_info->dir_name ? menu_info->dir_name : } panel_menu_button_create (toplevel, position, menu_path, use_menu_path, tooltip); } Just to make it a bit more clear
Committed to HEAD (with above changes incorporated).
*** Bug 133092 has been marked as a duplicate of this bug. ***