GNOME Bugzilla – Bug 120924
gnome printing integration
Last modified: 2005-09-28 00:18:33 UTC
epiphany is not well integrated with gnome printing capatibilities. 1 : You don't have the ability to choese your printer from a list contrary to gedit/evolution/... This is painfull in corporate environment when you have several printers. Having to give the name of the print ( -P Printername ) or use replace lpr by an other graphical print tool ( kprinter, xpp, ... ) is not user friendy. 2 : you can't specify if you want to print background, or at least if by selecting color it means background too, the printing is quality poor because of some limitations of mozilla ps generator. one solution could be to use or have a plugin for xprint ( http://xprint.mozdev.org/ ) thus allowing us to embedded fonts in Postcript, have printers list, etc ... This should be really fixed before 1.0 release
*** Bug 120486 has been marked as a duplicate of this bug. ***
I've already written a patch to gnomeprint-ify epiphany, and i'm looking into xprint too. > This should be really fixed before 1.0 release No way, we're in hard code freeze and 1.0 will be released shortly. It'll have to wait.
*** Bug 112619 has been marked as a duplicate of this bug. ***
Created attachment 19591 [details] [review] first patch, needs work -- testing & feedback appreciated (depends on gtk+ cvs head and gnomeprint(ui) 2.3.1)
chpe, could you explain how the thing works in general. Like the trick we use to have a gnomeprint dialog while not using gnomeprint ?
Sorry for the spam. Reassigning bugs with a target to our next milestone.
Created attachment 19924 [details] [review] updated patch
Created attachment 19925 [details] [review] new diff of print-dialog.c -- support margin settings
Marco, can you review the patch? I think i fixed most of the issues from the last time you commented about the patch: I moved the callback functions out of C++ files back into print-dialog.c, made PrintDialog inherit from GnomePrintDialog instead of mimicking EphyEmbedDialog, and fixed a few misc things. There are still some FIXMEs in the code, mostly owing to the fact that GnomePrintDialog and libgnomeprint suck.
/* FIXME: this was in xd2's gnomeprint patch for galeon, * what's it good for ? */ fflush(NULL); I'd figure out this with clahey before checking in. /* FIXME: warn on unsuccessful print (at least when printing to file) */ Better to fix this before committing. static gboolean printing_done_cb (GObject *data) { g_object_ref (data); g_idle_add ((GSourceFunc) printing_done_and_idle_cb, data); return TRUE; } Why are we doing this on idle ? // FIXME is this the right env var?? dir = g_getenv ("TMP"); g_get_tmp_dir ? // string = gnome_print_config_to_string (global_config, 0); // how to write config to file? // g_free (string); Should we just use a gconf key ? I'd say to look at what gedit does here. /* FIXME: append custom notebook page for margins, headers, footers, colour/grayscale, etc. */ I thought you implemented these ? I'd wait at least margins and headers/footers are implemented before committing. /* FIXME: we need to unref global_config and g_free config_file * somewhere on exit... */ Should fix before committing. // FIXME disable setting which are unsupported by gnomeprint's // ps backend [like print-to-PDF, combine pages etc.] Not sure if I get what you mean here. Disable where ? For comments should use /* */ You are constructing in _show too, but that could be called multiple times.
*** Bug 126303 has been marked as a duplicate of this bug. ***
Assigning to new "Printing" component.
Cc'ing chris, jody, and myself. I know this is currently marked 'low' priority but I personally think it's a big one- newbies want common printer dialogs everywhere, and this is the way we're currently trying to do it. If the gnomeprint stuff is in some way inadequate, please let jody know: he's tasked with improving it so that it is easier for the rest of GNOME to work with. It would be really great to get in the 2.8 release of ephy. Thanks...
Yeah, not sure why we actually marked it low.
Moving to a new one since there is way too much irrelevant stuff here. *** This bug has been marked as a duplicate of 141241 ***