GNOME Bugzilla – Bug 119878
Use the global canvas accelerator table in all docks (use same keyboard shortcuts in all windows)
Last modified: 2004-05-05 01:07:51 UTC
The keyboard shortcuts available on the layers tab do not seem to work when the layers tab is in focus. I've experienced this problem when the layers tab is docked to the main tool box as well as when the layers tab is in its own separate window (i.e., not docked to anything). I _can_ assign new shortcuts and override the default shortcuts on the layers tab, but they don't work either. I've been able to reproduce this bug on Gimp 1.3.12, 1.3.17 & 1.3.18. Let me know if I can provide any further info. Eric Pierce
The keyboard shortcuts in the docks are about to be removed. Instead, the global shortcut table as used in the canvas will be available globally. Changing bug title and milestone accordingly.
We're getting closer... 2003-09-01 Michael Natterer <mitch@gimp.org> * app/gui/channels-menu.c * app/gui/layers-menu.c * app/gui/vectors-menu.c: removed accelerators from popup menus. The HIG says nono and we will use the global <Image> accelerator table all over the place soon. First part of fix for bug #119878.
*** Bug 130311 has been marked as a duplicate of this bug. ***
Expanded the title a bit in order to make this bug easier to find.
*** Bug 132205 has been marked as a duplicate of this bug. ***
*** Bug 132275 has been marked as a duplicate of this bug. ***
Would it not be extremely handy to now have all the global keyboard shortcuts available no matter which Gimp dialog is in focus? For example, as it stands now, all the Layer keyboard shortcuts are no longer available when the layers dialog is in focus. That doesn't seem right. Couldn't you apply the global keyboard shortcuts to be available no matter which Gimp dialog window is in focus? Eric Pierce
This is exactly what this bug report is about.
Ok, this can be easily done for all docks except the toolbox. Merging the toolbox' menu shortcuts with the global ones needs GTK 2.4's new menu facilities. We have two options: (a) Use the global shortcuts for all docks except the toolbox (b) Bump this bug to 2.2 because (a) would be too confusing Opinions?
It's hard to imagine how (a) would feel - but I think it would feel rather confusing. I therefore vote for (b) - bumping this change to 2.2.
I think we should go for (a) because it would make 2.0 a lot more useable. Most of the time the focus goes between image windows and docks. If the image shortcuts would work from the docks, that would be a major improvement.
Fixed for all GimpDocks. Bumping to 2.2 because merging the accels with the toolbox ones needs GTK+ 2.4. 2004-01-31 Michael Natterer <mitch@gimp.org> Use the global <Image> accel_group in all docks except the toolbox (the latter needs GTK+ 2.4's new menu features). Addresses bug #119878: * app/gui/buffers-commands.c * app/gui/channels-commands.c * app/gui/data-commands.c * app/gui/documents-commands.c * app/gui/drawable-commands.c * app/gui/edit-commands.c * app/gui/file-commands.c * app/gui/gradients-commands.c * app/gui/image-commands.c * app/gui/layers-commands.c * app/gui/plug-in-commands.c * app/gui/select-commands.c * app/gui/tool-options-commands.c * app/gui/tools-commands.c * app/gui/vectors-commands.c * app/gui/view-commands.c: changed the various return_if_no_foo() macros to also accept a GimpDock as user_data. * app/gui/image-menu.c (image_menu_update): don't update the display related menu items if they don't exist (see below). * app/gui/gui.c (gui_display_changed): simplified. * app/widgets/gimpimagedock.[ch]: create an "<Image>" item_factory and attach its accel_group to the dock. Destroy all display related menu items. Destroy the layer stack navigation items because their default shortcuts interfere with tree and grid view keybindings. Connect to "image_changed" of the dock's private context and to "flush" of the image container to update the item_factory's state.
Mitchs change broke e.g. layer renaming. We definitely have to wait for GTK+ 2.4 to finally resolve this one. Disabled this in CVS HEAD again: 2004-03-04 Simon Budig <simon@gimp.org> * app/widgets/gimpimagedock.[ch]: #ifdef'ed the code for the global shortcuts and disabled it. Fixes bug #133453
*** Bug 139638 has been marked as a duplicate of this bug. ***
Fixed in CVS: 2004-05-05 Michael Natterer <mitch@gimp.org> Finally enable global accelerators in all docks: * app/widgets/gimpimagedock.c (gimp_image_dock_constructor): iterate all of the UI manager's actions and enable their accelerators manually. Fixes bug #119878.