After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 119120 - webbrowser plug-in depends on netscape
webbrowser plug-in depends on netscape
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other Linux
: Normal normal
: 2.0
Assigned To: Henrik Brix Andersen
Henrik Brix Andersen
Depends on:
Blocks:
 
 
Reported: 2003-08-04 19:37 UTC by Henrik Brix Andersen
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Henrik Brix Andersen 2003-08-04 19:37:35 UTC
The webbrowser plug-in found in '<Xtns>/Webbrowser' depends on netscape to
be installed. I suggest we either:

a) check for available browsers at compile time and hardcode either
mozilla/netscape in plug-ins/webbrowser/webbrowser.c

b) get rid of the webbrowser plug-in. it's a bit of a hack and not really
needed/used(?). We can then add an entry like '<Help>/The GIMP Web Site'
(but this would require us to check for available browser too?)

c) change plug-ins/webbrowser/webbrowser.c to use 'mozilla' as default
browser. This is the easy-fix.

Please comment on this...
Comment 1 Sven Neumann 2003-08-05 11:59:18 UTC
This is basically a duplicate of bug #51632.

A standard for configuring the desktop-wide browser is being discussed
at the free desktop mailing-list. We should use this standard when it
becomes available.
Comment 2 Henrik Brix Andersen 2003-08-21 13:48:08 UTC
I think we need to come up with at least a temporary solution to this
problem before 2.0 is released... I suggest we remove the plug-in
since it's a bit of a hack already.

When freedesktop.org comes up with a standard we can consider adding a
"<Help>/GIMP Online" menu entry.

Which reminds me - we've discussed having the (hopefully?) upcoming
gimp-help-browser offer a link directly to the neweste version of the
shown help page online. For this functionality we need a way to
communicate with an external browser process as well...
Comment 3 Henrik Brix Andersen 2003-09-22 20:07:25 UTC
Fixed in CVS HEAD:

2003-09-22  Henrik Brix Andersen  <brix@gimp.org>

	Replaced the netscape-dependent web browser plug-in with a
	user configureable plug-in. This fixes bug #119120:

	* app/config/gimpguiconfig.[ch]: added gchar *web_browser 
	member

	* app/config/gimprc-blurbs.h: added web browser blurb

	* etc/gimprc
	* docs/gimprc-1.3.5.in: regenerated using gimpconfig-dump

	* app/gui/preferences-dialog.c (prefs_dialog_new): added UI
	for specifying external web browser

	* configure.in
	* plug-ins/Makefile.am
	* plug-ins/webbrowser/Makefile.am
	* plug-ins/webbrowser/README
	* plug-ins/webbrowser/web-browser.scm
	* plug-ins/webbrowser/webbrowser.c : removed the old
	netscape-dependent web browser plug-in

	* po-plug-ins/POTFILES.in
	* plug-ins/common/plugin-defs.pl
	* plug-ins/common/webbrowser.c: added a new web browser
	plug-in

	* plug-ins/common/.cvsignore
	* plug-ins/common/Makefile.am: regenerated

	* app/widgets/gimphelp.c
	* app/widgets/widget-enums.[ch]
	* plug-ins/helpbrowser/dialog.c
	* plug-ins/maze/maze_face.c: changed accordingly + whitespace
	clean-up

	* po-script-fu/POTFILES.in
	* plug-ins/script-fu/scripts/Makefile.am
	* plug-ins/script-fu/scripts/web-browser.scm: use the new web
	browser plug-in to add menu entries to <Toolbox>/Help/