After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 118646 - gtkctree cuts descenders when rendering
gtkctree cuts descenders when rendering
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.2.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 90524 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-07-30 08:56 UTC by Charles Kerr
Modified: 2011-02-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (554 bytes, patch)
2003-07-30 08:57 UTC, Charles Kerr
none Details | Review

Description Charles Kerr 2003-07-30 08:56:47 UTC
This is a continuation of http://bugzilla.gnome.org/show_bug.cgi?id=65002:

  > in In GtkCList, the rows do not appear to be tall enough.
  > The descenders of letters are clipped. (like the bottom of 'g')

Owen checked in gtkctree.c 1.97 and marked the bug as fixed,
which it was, except for text in ctree->ctree_column, which is
drawn in a different piece of the code to handle the expander
box.  Attached is a patch that applies Owen's fix to that column.

As a reference, here's Owen's original patch that fixed the other columns:
http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvs/gnome&subdir=gtk+/gtk&command=DIFF_FRAMESET&file=gtkctree.c&rev2=1.97&rev1=1.96
Comment 1 Charles Kerr 2003-07-30 08:57:31 UTC
Created attachment 18749 [details] [review]
proposed fix
Comment 2 Charles Kerr 2003-07-30 08:57:54 UTC
*** Bug 90524 has been marked as a duplicate of this bug. ***
Comment 3 Charles Kerr 2003-07-30 09:04:09 UTC
*** Bug 107321 has been marked as a duplicate of this bug. ***
Comment 4 Owen Taylor 2003-08-04 15:05:24 UTC
Looks fine to commit (gtk-2-2 and HEAD)