After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 118540 - Dynamic bidi base direction for GtkEntry
Dynamic bidi base direction for GtkEntry
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.2.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 70451
Blocks:
 
 
Reported: 2003-07-29 03:45 UTC by Owen Taylor
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revised patch (6.72 KB, patch)
2003-07-30 18:55 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2003-07-29 03:45:23 UTC 
The base direction for GtkEntry should be based on the
contents of the entry and the current state of the
keyboard, rather statically determined by 
gtk_widget_get_direction(). See bug 70451.

[ Filing separate bugs for each widget, since I find 
  bugs with lots of different things going on hard to
  work with ]
Comment 1 Owen Taylor 2003-07-30 18:52:13 UTC 
Changes from your version:

 - Renamed p_dir variables to pango_dir

 - Removed call:

                                                                     
                pango_layout_set_alignment (layout, pango_dir);

   Doesn't make any real sense (wrong type for the argument...)
   and shouldn't be necessary. Alignment doesn't have an
   effect for single-line layouts.
                                                                     
          
 - Introduced draw_insertion_cursor() utility function to clean
   up insertion-cursor drawing code.

 - Call gtk_entry_recompute() in gtk_entry_keymap_direction_changed()
   instead of doing the operations synchronously.

 - Removed unused widget_direction variables in gtkentry.c

 - Indentation fixes

 - Changed resolved_dir into a bitfield and moved it into
   the bitfield block; initial patch broke bin-compat
   by changing the size of the GtkEntry structure.
Comment 2 Owen Taylor 2003-07-30 18:55:11 UTC 
Created attachment 18764 [details] [review]
Revised patch
Comment 3 Owen Taylor 2004-03-01 15:41:03 UTC 
Mon Mar  1 10:31:11 2004  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkentry.c: Implement auto-bidi-direction,
        based on a patch from Dov Grobgeld. (#118540)