After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 117449 - EOG msgid includes non-ASCII character breaking gettext
EOG msgid includes non-ASCII character breaking gettext
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other All
: Normal major
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-07-15 10:23 UTC by Christian Rose
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4



Description Christian Rose 2003-07-15 10:23:25 UTC
xgettext: warning: The following msgid contains non-ASCII characters.
                   This will cause problems to translators who use a
character encoding
                   different from yours. Consider using a pure ASCII msgid
instead.
                   Copyright © 2000-2003 The Free Software Foundation
xgettext: invalid multibyte sequence
xgettext: invalid multibyte sequence
xgettext: invalid multibyte sequence
xgettext: invalid multibyte sequence

The problem seems to come from the shell/eog-window.c file.
Non-ASCII characters are not allowed inside msgids due to gettext
limitations. Please see
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-ascii
for details.


I suggest this message be changed into:

  "Copyright © 2000-2003 Free Software Foundation, Inc."

and NOT be marked for translation. This has the following advantages:
  * The FSF wants to be referred to as "Free Software Foundation, Inc."
  * Avoiding "the" means that the name doesn't need localization
  * Copyright information should in most cases not be localized anyway
  * The proper copyright symbol can be used
  and
  * Gettext won't complain.
Comment 1 Christian Rose 2003-07-16 08:11:35 UTC
Appearantly, this message was changed by Jens Finke on 2003-07-02
(http://cvs.gnome.org/bonsai/cvsblame.cgi?file=eog%2Fshell/eog-window.c&rev=&root=/cvs/gnome).
The commit message claims this was a fix for bug 101726, but strangely
enough the patch provided in that bug does not expose either of these
problems -- it (correctly) doesn't mark this message for translation,
and it correctly refers to "Free Software Foundation, Inc."

So something went very wrong when applying that patch. Jens?
Comment 2 Jens Finke 2003-07-16 15:36:19 UTC
Sorry, I didn't read the patch well enough and made the change manually. 
Now, this should be fixed in head like it was suggested in the
original bug report.
Comment 3 Christian Rose 2003-07-16 17:10:27 UTC
Thanks for fixing it!