GNOME Bugzilla – Bug 117439
gedit-plugins failing to compile
Last modified: 2019-03-23 20:33:11 UTC
The Compare Files plugin is failing to compile with the following error: Making all in diff make[3]: Entering directory `/home1/gedit-plugins/plugins/diff' source='diff.c' object='diff.lo' libtool=yes \ depfile='.deps/diff.Plo' tmpdepfile='.deps/diff.TPlo' \ depmode=none /bin/bash ../../depcomp \ /bin/bash ../../libtool --mode=compile cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../src -DORBIT2=1 -mt -I/opt/gnome-2.0/include/gedit-2.4 -I/opt/gnome-2.0/include/libgnomeui-2.0 -I/opt/gnome-2.0/include/libglade-2.0 -I/opt/gnome-2.0/include/libgnomeprintui-2.2 -I/opt/gnome-2.0/include/eel-2 -I/opt/gnome-2.0/include/gtksourceview-1.0 -I/opt/gnome-2.0/include/libgnome-2.0 -I/opt/gnome-2.0/include/libgnomecanvas-2.0 -I/opt/gnome-2.0/include/gtk-2.0 -I/opt/gnome-2.0/include/libart-2.0 -I/opt/gnome-2.0/include/gconf/2 -I/opt/gnome-2.0/include/libbonoboui-2.0 -I/opt/gnome-2.0/include/glib-2.0 -I/opt/gnome-2.0/lib/glib-2.0/include -I/opt/gnome-2.0/include/orbit-2.0 -I/opt/gnome-2.0/include/libbonobo-2.0 -I/opt/gnome-2.0/include/gnome-vfs-2.0 -I/opt/gnome-2.0/lib/gnome-vfs-2.0/include -I/opt/gnome-2.0/include/bonobo-activation-2.0 -I/opt/gnome-2.0/include/pango-1.0 -I/opt/gnome-2.0/include -I/opt/gnome-2.0/include/freetype2 -I/opt/gnome-2.0/lib/gtk-2.0/include -I/opt/gnome-2.0/include/atk-1.0 -I/usr/openwin/include -I/opt/gnome-2.0/include/libxml2 -I/opt/gnome-2.0/include/libgnomeprint-2.2 -I/opt/gnome-2.0/include/gail-1.0 -DGNOME_ICONDIR=\""/home1/gnome-2//share/pixmaps"\" -DGEDIT_GLADEDIR=\""/home1/gnome-2//share/gedit-2/glade/"\" -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -I/opt/gnome-2.0/include -g -I/opt/gnome-2.0/include -c -o diff.lo `test -f 'diff.c' || echo './'`diff.c cc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../src -DORBIT2=1 -mt -I/opt/gnome-2.0/include/gedit-2.4 -I/opt/gnome-2.0/include/libgnomeui-2.0 -I/opt/gnome-2.0/include/libglade-2.0 -I/opt/gnome-2.0/include/libgnomeprintui-2.2 -I/opt/gnome-2.0/include/eel-2 -I/opt/gnome-2.0/include/gtksourceview-1.0 -I/opt/gnome-2.0/include/libgnome-2.0 -I/opt/gnome-2.0/include/libgnomecanvas-2.0 -I/opt/gnome-2.0/include/gtk-2.0 -I/opt/gnome-2.0/include/libart-2.0 -I/opt/gnome-2.0/include/gconf/2 -I/opt/gnome-2.0/include/libbonoboui-2.0 -I/opt/gnome-2.0/include/glib-2.0 -I/opt/gnome-2.0/lib/glib-2.0/include -I/opt/gnome-2.0/include/orbit-2.0 -I/opt/gnome-2.0/include/libbonobo-2.0 -I/opt/gnome-2.0/include/gnome-vfs-2.0 -I/opt/gnome-2.0/lib/gnome-vfs-2.0/include -I/opt/gnome-2.0/include/bonobo-activation-2.0 -I/opt/gnome-2.0/include/pango-1.0 -I/opt/gnome-2.0/include -I/opt/gnome-2.0/include/freetype2 -I/opt/gnome-2.0/lib/gtk-2.0/include -I/opt/gnome-2.0/include/atk-1.0 -I/usr/openwin/include -I/opt/gnome-2.0/include/libxml2 -I/opt/gnome-2.0/include/libgnomeprint-2.2 -I/opt/gnome-2.0/include/gail-1.0 -DGNOME_ICONDIR=\"/home1/gnome-2//share/pixmaps\" -DGEDIT_GLADEDIR=\"/home1/gnome-2//share/gedit-2/glade/\" -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -I/opt/gnome-2.0/include -g -I/opt/gnome-2.0/include -c diff.c -KPIC -DPIC -o diff.o "diff.c", line 709: prototype mismatch: 3 args passed, 4 expected "diff.c", line 744: prototype mismatch: 3 args passed, 4 expected "diff.c", line 863: warning: statement not reached cc: acomp failed for diff.c make[3]: *** [diff.lo] Error 1 make[3]: Leaving directory `/home1/gedit-plugins/plugins/diff' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home1/gedit-plugins/plugins' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home1/gedit-plugins' make: *** [all] Error 2 I have observed this while compiling plugins on RH7.1 and Solaris 9.
The function gedit_document_save_a_copy_as () is being used in Compare Files plugin. The arguments passed to this function has been changed from 3 to 4. But the gedit-plugins has not been updated with these changes.
Created attachment 19255 [details] [review] updated diff/cvschangelog for correct parameters
cc'ing self
Adding PATCH keyword, pushing priority up to HIGH
*** Bug 120059 has been marked as a duplicate of this bug. ***
Fixed in CVS HEAD