After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116896 - message dialogs should have window icons
message dialogs should have window icons
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Widget: Other
2.2.x
Other Linux
: Normal normal
: future
Assigned To: gtk-bugs
gtk-bugs
: 74310 (view as bug list)
Depends on: 92346
Blocks:
 
 
Reported: 2003-07-07 15:50 UTC by Mark McLoughlin
Modified: 2004-12-23 05:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.55 KB, patch)
2003-07-07 15:51 UTC, Mark McLoughlin
needs-work Details | Review

Description Mark McLoughlin 2003-07-07 15:50:39 UTC
Attaching a patch to make message dialogs set an appropriate window icon
Comment 1 Mark McLoughlin 2003-07-07 15:51:16 UTC
Created attachment 18102 [details] [review]
patch
Comment 2 Mark McLoughlin 2003-07-07 15:51:56 UTC
PATCH -> High
Comment 3 Owen Taylor 2003-08-22 16:51:31 UTC
Is it right to have the generic icon, or is it better to have
the app icon? After all, there's already a big picture of the
icon there, maybe an indication of the app would be better.

Thoughts on the patch:

 - The icon really needs to update with the theme

 - It would be nice to have use all sizes in the icon
   list rather than just GTK_ICON_SIZE_DIALOG

 - We definitely want to implement named-icon support
   for window icons (bug 92346). Since stock icons
   should have a corresponding named-icon, and since
   the special features of stock icons (symbolic sizes,
   dependence on widget state, etc) aren't useful,
   we can implement this with that, rather than adding
   special support for stock icons for window icons,
   which doesn't seem generally useful.
Comment 4 Seth Nickell 2003-08-23 03:30:26 UTC
App modal message dialogs shouldn't show up in the window list, so the window icon is of lesser importance then it'd otherwise be (of course the icon could show up in the wm titlebar, etc). Associating the message dialog w/ the window oer application that generated it is more important than providing yet another place to incdicate the type of dialog (this actually isn't very good info to communicate w/ an icon anyway... The distinction between the types is fairly slim and not really "actionable information". Arguably it'd be better to use the generating app's icon rather than a stock "warning", "question" etc in the main icon too but I digress).
Comment 5 Jason Leach 2004-01-27 06:25:46 UTC
*** Bug 74310 has been marked as a duplicate of this bug. ***