GNOME Bugzilla – Bug 116896
message dialogs should have window icons
Last modified: 2004-12-23 05:01:39 UTC
Attaching a patch to make message dialogs set an appropriate window icon
Created attachment 18102 [details] [review] patch
PATCH -> High
Is it right to have the generic icon, or is it better to have the app icon? After all, there's already a big picture of the icon there, maybe an indication of the app would be better. Thoughts on the patch: - The icon really needs to update with the theme - It would be nice to have use all sizes in the icon list rather than just GTK_ICON_SIZE_DIALOG - We definitely want to implement named-icon support for window icons (bug 92346). Since stock icons should have a corresponding named-icon, and since the special features of stock icons (symbolic sizes, dependence on widget state, etc) aren't useful, we can implement this with that, rather than adding special support for stock icons for window icons, which doesn't seem generally useful.
App modal message dialogs shouldn't show up in the window list, so the window icon is of lesser importance then it'd otherwise be (of course the icon could show up in the wm titlebar, etc). Associating the message dialog w/ the window oer application that generated it is more important than providing yet another place to incdicate the type of dialog (this actually isn't very good info to communicate w/ an icon anyway... The distinction between the types is fairly slim and not really "actionable information". Arguably it'd be better to use the generating app's icon rather than a stock "warning", "question" etc in the main icon too but I digress).
*** Bug 74310 has been marked as a duplicate of this bug. ***