After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116872 - GOK should exit gracefully if a11y support is disabled
GOK should exit gracefully if a11y support is disabled
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
Depends on:
Blocks: 92670
 
 
Reported: 2003-07-07 12:07 UTC by Calum Benson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The warning dialog screenshot for when accessibility is not set. (22.70 KB, image/png)
2003-07-15 15:30 UTC, David Bolter
Details
Re-saved David's screenshot so that the text is clearer (22.70 KB, image/png)
2003-07-16 08:45 UTC, Eugene O'Connor
Details

Description Calum Benson 2003-07-07 12:07:02 UTC
Right now you can happily start GOK if a11y support is turned off.  Suggest
any AT that relies on a11y support should check this first and pop up a
warning such as:

<bold><larger>Assistive Technology support not enabled</larger></bold>

[appname] requires assistive technology support to be 
enabled in the Assistive Technology Support preferences 
window.  You can do this now but the change will not take
effect until you next log in.

            [Enable and Log Out] [Enable and Close] [Close]

None of the buttons should start the application (or is there any reason to
start the application anyway?)   Close should just dismiss the alert
window.  Enable and Close should turn on AT support and dismiss the alert
window.  Enable and Log Out should turn on AT support and log the user out
of their current session.  None of the three actions should start the
application... unless there is ever a reason to start the application with
AT support disabled?

Cc'ing docs guys for thoughts on the alert wording...
Comment 1 Calum Benson 2003-07-07 12:07:36 UTC
See #116871 for the equivalent gnopernicus bug...
Comment 2 David Bolter 2003-07-07 14:18:29 UTC
GOK is still useful with a11y turned off since regular key synthesis
can be done through the at-spi library even though applications are
not being registered with bonobo etc...  Key synthesis doesn't care if
current application is "accessible" or not.

For this reason, I wouldn't want to force the user to close gok.  I do
think there needs to be some indication that they should turn a11y on
though.  Perhaps rewording the message and adding an ignore button?
Comment 3 Calum Benson 2003-07-07 16:04:39 UTC
Ah, fair enough... then yeah, probably want something more like:

<bold><larger>Assistive Technology support not enabled</larger></bold>

If you continue without enabling assistive technology
support for your desktop, some features of this application 
may not be available.  If you enable assistive technology 
support now, the change will not take effect until you 
next log in.

                   [Enable and Log Out] [Cancel] [Continue]


where Continue carries on regardless, Cancel closes the alert and
stops running GOK, and Enable and Log Out does just that.
Comment 4 David Bolter 2003-07-07 16:19:00 UTC
Looks good to me, thanks Calum.
Comment 5 Calum Benson 2003-07-07 17:02:48 UTC
I guess one question then is, if you choose "Enable and Log Out",
should GOK start up again automatically when you next log in.  I think
I'll leave that one up to you though :)
Comment 6 David Bolter 2003-07-14 16:17:20 UTC
Calum, All,

I am just getting around to implementing this.  Are you sure we need a
Cancel that quits gok?  Also, I don't see stock buttons for continue
or enable... which leads me to suspect that this dialog is non
standard?  (I've also poked around the HIG document).  I can implement
this but I am curious to know what the cc'ed folks think...  (BTW I
notice the gnopernicus folks strayed from your suggestion -- perhaps
there was some discussion I am not aware of?).
Comment 7 irene.ryan 2003-07-14 18:00:40 UTC
I have some comments on the text of the warning message. One thing
though....I have not seen the "Assistive Technology Support
preferences dialog so I'm wondering if we need to say "Assistive
Technology Support" or just "Accessibility Support"?  

Anyway, I suggest the following wording:

----- START OF MESSAGE -----

<bold>Assistive Technology Support Is Not Enabled</bold>

You can start GOK without enabling support for assistive technologies.
However, some of the features of the application may not be available.

To enable support for assistive technologies and log in to a new
session with the change enabled, click Enable and Log Out. 

To continue to start GOK, click Continue.

To quit GOK, click Cancel. 

----- END OF MESSAGE -----
Comment 8 Eugene O'Connor 2003-07-15 10:31:29 UTC
Minor suggestion:

s/application may not be available/application might not be available
Comment 9 David Bolter 2003-07-15 15:29:06 UTC
Thanks all for your suggestions.  I will attach a screenshot of the
dialog so far. The functionality is all there except for automating
the logout precedure. Any advice on that part?
(It is in CVS head if you want to try it).
Comment 10 David Bolter 2003-07-15 15:30:31 UTC
Created attachment 18309 [details]
The warning dialog screenshot for when accessibility is not set.
Comment 11 irene.ryan 2003-07-15 16:51:43 UTC
David - can you retake the screenshot? The colours are screwed up and
it's hard to read. Thanks!
Comment 12 David Bolter 2003-07-15 17:28:30 UTC
I don't think retaking the screenshot will help.  Perhaps it is my RGB
palette settings.  I don't have time to change my X settings right
now.  I wonder if you could import it into gimp and make it more
legible?  I am not sure how to do that myself.
Comment 13 Eugene O'Connor 2003-07-16 08:45:40 UTC
Created attachment 18340 [details]
Re-saved David's screenshot so that the text is clearer
Comment 14 Eugene O'Connor 2003-07-16 08:48:50 UTC
David, Irene, FYI, here's waht I did: I downloaded the screenshot. In
GIMP 1.2 I re-saved it as PNG, and in the Save as PNG dialog, I
deselected the Save background color option.
Comment 15 Calum Benson 2003-07-16 11:37:59 UTC
No, I'm not really sure if we need an option that quits GOK,
particularly if it remains as functional as you say with a11y support
turned off... you know more about how people use this and what
will/won't work so that's your call really.  I had it in there because
alerts are generally of the form "something is wrong, do you want to
do something about it or cancel", rather than "something is wrong, but
I'm not going to give you the option to back out", but that's for a
definition of "wrong" that potentially doesn't apply here.

As for the gnopi folks, no, there wasn't any other discussion other
than what's in the bug, but I wouldn't copy them just yet as the HIG
strongly advises against using alerts with Yes/No buttons in them :)

BTW, marking this as a ui-review bug so you can officially continue to
tweak it now the UI freeze is past...
Comment 16 David Bolter 2003-07-16 13:13:59 UTC
Eugene, thanks for telling me how to do the screenshot modification.

Calum, thanks for the info. I suppose I should alert you when/if I am
going to make user-visible changes until 2.4? 
Comment 17 Calum Benson 2003-07-16 14:38:56 UTC
Yes, only ui-review changes are allowed before 2.4 now, so any
proposed UI changes ought to be logged as bugs with the ui-review
keyword, cc'ed to usability-maint@bugzilla.gnome.org, and approved by
someone who's allowed to approve that sort of thing :)  (I'm usually
sufficient...)
Comment 18 Calum Benson 2003-08-07 16:14:05 UTC
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 19 bill.haneman 2003-08-22 17:20:24 UTC
I think we should just put up an informational dialog that alerts the
user to the fact that some GOK features won't be available, without
including the extra stuff.   At most we could include a 'Help' button
that took the user to the document describing how to turn on
accessibility support in GNOME.

In which case, I think we should be able to get approval for this
right away, i.e. it's needed before 2.4 is complete!
Comment 20 David Bolter 2003-08-22 17:38:52 UTC
Bill, I commited to cvs quite a while ago an almost complete solution
to this bug.  You can see the dialog if you run gok with accessibility
turned off.  The only remaining piece of the puzzle is the automatic
logout...  which is why I left this bug open.
Comment 21 David Bolter 2003-09-04 12:49:29 UTC
Implemented in CVS except for logging out which is captured by bug 121445